mirror of
https://github.com/siteboon/claudecodeui.git
synced 2026-05-30 08:15:31 +08:00
Refactor/shared and tasks components (#473)
* refactor: remove unused TasksSettings component
* refactor: migrate TodoList component to a new file with improved structure and normalization logic
* refactor: Move Tooltip and DarkModeToggle to shared/ui
* refactor: Move Tooltip and DarkModeToggle to shared/view/ui
* refactor: move GeminiLogo to llm-logo-provider and update imports
* refactor: remove unused GeminiStatus component
* refactor: move components in src/components/ui to src/shared/view/ui
* refactor: move ErrorBoundary component to main-content/view and update imports
* refactor: move VersionUpgradeModal to its own module
* refactor(wizard): rebuild project creation flow as modular TypeScript components
Replace the monolithic `ProjectCreationWizard.jsx` with a feature-based TS
implementation under `src/components/project-creation-wizard`, while preserving
existing behavior and improving readability, maintainability, and state isolation.
Why:
- The previous wizard mixed API logic, flow state, folder browsing, and UI in one file.
- Refactoring and testing were difficult due to tightly coupled concerns.
- We needed stronger type safety and localized component state.
What changed:
- Deleted:
- `src/components/ProjectCreationWizard.jsx`
- Added new modular structure:
- `src/components/project-creation-wizard/index.ts`
- `src/components/project-creation-wizard/ProjectCreationWizard.tsx`
- `src/components/project-creation-wizard/types.ts`
- `src/components/project-creation-wizard/data/workspaceApi.ts`
- `src/components/project-creation-wizard/hooks/useGithubTokens.ts`
- `src/components/project-creation-wizard/utils/pathUtils.ts`
- `src/components/project-creation-wizard/components/*`
- `WizardProgress`, `WizardFooter`, `ErrorBanner`
- `StepTypeSelection`, `StepConfiguration`, `StepReview`
- `WorkspacePathField`, `GithubAuthenticationCard`, `FolderBrowserModal`
- Updated import usage:
- `src/components/sidebar/view/subcomponents/SidebarModals.tsx`
now imports from `../../../project-creation-wizard`.
Implementation details:
- Migrated wizard logic to TypeScript using `type` aliases only.
- Kept component prop types colocated in each component file.
- Split responsibilities by feature:
- container/orchestration in `ProjectCreationWizard.tsx`
- API/SSE and request parsing in `data/workspaceApi.ts`
- GitHub token loading/caching behavior in `useGithubTokens`
- path/URL helpers in `utils/pathUtils.ts`
- Localized UI-only state to child components:
- folder browser modal state (current path, hidden folders, create-folder input)
- path suggestion dropdown state with debounced lookup
- Preserved existing UX flows:
- step navigation and validation
- existing/new workspace modes
- optional GitHub clone + auth modes
- clone progress via SSE
- folder browsing + folder creation
- Added focused comments for non-obvious logic (debounce, SSE auth constraint, path edge cases).
* refactor(quick-settings): migrate panel to typed feature-based modules
Refactor QuickSettingsPanel from a single JSX component into a modular TypeScript feature structure while preserving behavior and translations.
Highlights:
- Replace legacy src/components/QuickSettingsPanel.jsx with a typed entrypoint (src/components/QuickSettingsPanel.tsx).
- Introduce src/components/quick-settings-panel/ with clear separation of concerns:
- view/: panel shell, header, handle, section wrappers, toggle rows, and content sections.
- hooks/: drag interactions and whisper mode persistence.
- constants.ts and types.ts for shared config and strict local typing.
- Move drag logic into useQuickSettingsDrag with explicit touch/mouse handling, drag threshold detection, click suppression after drag, position clamping, and localStorage persistence.
- Keep user-visible behavior intact:
- same open/close panel interactions.
- same mobile/desktop drag behavior and persisted handle position.
- same quick preference toggles and wiring to useUiPreferences.
- same hidden whisper section behavior and localStorage/event updates.
- Improve readability and maintainability by extracting repetitive setting rows and section scaffolding into reusable components.
- Add focused comments around non-obvious behavior (drag click suppression, touch scroll lock, hidden whisper section intent).
- Keep files small and reviewable (all new/changed files are under 300 lines).
Validation:
- npm run typecheck
- npm run build
* refactor(quick-settings-panel): restructure QuickSettingsPanel import and create index file
* refactor(shared): move shared ui components to share/view/ui without subfolders
* refactor(LanguageSelector): move LanguageSelector to shared UI components
* refactor(prd-editor): modularize PRD editor with typed feature modules
Break the legacy PRDEditor.jsx monolith into a feature-based TypeScript architecture under src/components/prd-editor while keeping behavior parity and readability.
Key changes:
- Replace PRDEditor.jsx with a typed orchestrator component and a compatibility export bridge at src/components/PRDEditor.tsx.
- Split responsibilities into dedicated hooks: document loading/init, existing PRD registry fetching, save workflow with overwrite detection, and keyboard shortcuts.
- Split UI into focused view components: header, editor/preview body, footer stats, loading state, generate-tasks modal, and overwrite-confirm modal.
- Move filename concerns into utility helpers (sanitize, extension handling, default naming) and centralize template/constants.
- Keep component-local state close to the UI that owns it (workspace controls/modal toggles), while shared workflow state remains in the feature container.
- Reuse the existing MarkdownPreview component for safer markdown rendering instead of ad-hoc HTML conversion.
- Update TaskMasterPanel integration to consume typed PRDEditor directly (remove any-cast) and pass isExisting metadata for correct overwrite behavior.
- Keep all new/changed files below 300 lines and add targeted comments where behavior needs clarification.
Validation:
- npm run typecheck
- npm run build
* refactor(TaskMasterPanel): update PRDEditor import path to match new structure
* refactor(TaskMaster): Remove unused TaskMasterSetupWizard and TaskMasterStatus components
* refactor(TaskDetail): remove unused TaskIndicator import
* refactor(task-master): migrate tasks to a typed feature module
- introduce a new feature-oriented TaskMaster domain under src/components/task-master
- add typed TaskMaster context/provider with explicit project, task, MCP, and loading state handling
- split task UI into focused components (panel, board, toolbar, content, card, detail modal, setup/help modals, banner)
- move task board filtering/sorting/kanban derivation into dedicated hooks and utilities
- relocate CreateTaskModal into the feature module and keep task views modular/readable
- remove legacy monolithic TaskList/TaskDetail/TaskCard files and route main task panel to the new feature panel
- replace contexts/TaskMasterContext.jsx with a typed contexts/TaskMasterContext.ts re-export to the feature context
- update MainContent project sync logic to compare by project name to avoid state churn
- validation: npm run typecheck, npm run build
* refactor(MobileNav): remove unused React import and TaskMasterContext
* refactor(auth): migrate login and setup flows to typed feature module
- Introduce a new feature-based auth module under src/components/auth with clear separation of concerns:\n - context/AuthContext.tsx for session lifecycle, onboarding status checks, token persistence, and auth actions\n - view/* components for loading, route guarding, form layout, input fields, and error display\n - shared auth constants, utility helpers, and type aliases (no interfaces)\n- Convert login and setup UIs to TypeScript and keep form state local to each component for readability and component-level ownership\n- Add explicit API payload typing and safe JSON parsing helpers to improve resilience when backend responses are malformed or incomplete\n- Centralize error fallback handling for auth requests to reduce repeated logic
- Replace legacy auth entrypoints with the new feature module in app wiring:\n - App now imports AuthProvider and ProtectedRoute from src/components/auth\n - WebSocketContext, TaskMasterContext, and Onboarding now consume useAuth from the new typed auth context\n- Remove duplicated legacy auth screens (LoginForm.jsx, SetupForm.jsx, ProtectedRoute.jsx)\n- Keep backward compatibility by turning src/contexts/AuthContext.jsx into a thin re-export of the new provider/hook
Result: auth code now follows a feature/domain structure, is fully typed, easier to navigate, and cleaner to extend without touching unrelated UI areas.
* refactor(AppContent): update MobileNav import path and add MobileNav component
* refactor(DiffViewer): rename different diff viewers and place them in different components
* refactor(components): reorganize onboarding/provider auth/sidebar indicator into domain features
- Move onboarding out of root-level components into a dedicated feature module:
- add src/components/onboarding/view/Onboarding.tsx
- split onboarding UI into focused subcomponents:
- OnboardingStepProgress
- GitConfigurationStep
- AgentConnectionsStep
- AgentConnectionCard
- add onboarding-local types and utils for provider status and validation helpers
- Move multi-provider login modal into a dedicated provider-auth feature:
- add src/components/provider-auth/view/ProviderLoginModal.tsx
- add src/components/provider-auth/types.ts
- keep provider-specific command/title behavior and Gemini setup guidance
- preserve compatibility for both onboarding flow and settings login flow
- Move TaskIndicator into the sidebar domain:
- add src/components/sidebar/view/subcomponents/TaskIndicator.tsx
- update SidebarProjectItem to consume local sidebar TaskIndicator
- Update integration points to the new structure:
- ProtectedRoute now imports onboarding from onboarding feature
- Settings now imports ProviderLoginModal directly (remove legacy cast wrapper)
- git panel consumers now import shared GitDiffViewer by explicit name
- Rename git shared diff view to clearer domain naming:
- replace shared DiffViewer with shared GitDiffViewer
- update FileChangeItem and CommitHistoryItem imports accordingly
- Remove superseded root-level legacy components:
- delete src/components/LoginModal.jsx
- delete src/components/Onboarding.jsx
- delete src/components/TaskIndicator.jsx
- delete old src/components/git-panel/view/shared/DiffViewer.tsx
- Result:
- clearer feature boundaries (auth vs onboarding vs provider-auth vs sidebar)
- easier navigation and ownership by domain
- preserved runtime behavior with improved readability and modularity
* refactor(MainContent): remove TaskMasterPanel import and relocate to task-master component
* fix: update import paths for Input component in FileTree and FileTreeNode
* refactor(FileTree): make file tree context menu a typescript component and move it inside the file tree view
* refactor(FileTree): remove unused ScrollArea import
* feat: setup eslint with typescript and react rules, add unused imports plugin
* fix: remove unused imports, functions, and types after discovering using `npm run lint`
* feat: setup eslint-plugin-react, react-refresh, import-x, and tailwindcss plugins with recommended rules and configurations
* chore: reformat files after running `npm run lint:fix`
* chore: add omments about eslint config plugin uses
* feat: add husky and lint-staged for pre-commit linting
* feat: setup commitlint with conventional config
* fix: i18n translations
---------
Co-authored-by: Haileyesus <something@gmail.com>
Co-authored-by: viper151 <simosmik@gmail.com>
This commit is contained in:
Haileyesus
312
src/components/file-tree/view/FileContextMenu.tsx
Normal file
312
src/components/file-tree/view/FileContextMenu.tsx
Normal file
@@ -0,0 +1,312 @@
|
||||
import { Fragment, useCallback, useEffect, useMemo, useRef, useState, type MouseEvent as ReactMouseEvent, type ReactNode } from 'react';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { Copy, Download, FileText, FolderPlus, Pencil, RefreshCw, Trash2, type LucideIcon } from 'lucide-react';
|
||||
import { cn } from '../../../lib/utils';
|
||||
|
||||
type FileContextItem = {
|
||||
name: string;
|
||||
type: 'file' | 'directory';
|
||||
path: string;
|
||||
size?: number;
|
||||
modified?: string;
|
||||
permissionsRwx?: string;
|
||||
children?: FileContextItem[];
|
||||
[key: string]: unknown;
|
||||
};
|
||||
|
||||
type ContextMenuAction = {
|
||||
key: string;
|
||||
label: string;
|
||||
icon?: LucideIcon;
|
||||
onSelect?: () => void;
|
||||
isDanger?: boolean;
|
||||
isDisabled?: boolean;
|
||||
shortcut?: string;
|
||||
showDividerBefore?: boolean;
|
||||
};
|
||||
|
||||
const CONTEXT_MENU_WIDTH = 200;
|
||||
const CONTEXT_MENU_HEIGHT = 300;
|
||||
const VIEWPORT_PADDING = 10;
|
||||
|
||||
function calculateViewportSafePosition(clientX: number, clientY: number) {
|
||||
// Keep the context menu inside the visible viewport.
|
||||
const safeX =
|
||||
clientX + CONTEXT_MENU_WIDTH > window.innerWidth
|
||||
? window.innerWidth - CONTEXT_MENU_WIDTH - VIEWPORT_PADDING
|
||||
: clientX;
|
||||
const safeY =
|
||||
clientY + CONTEXT_MENU_HEIGHT > window.innerHeight
|
||||
? window.innerHeight - CONTEXT_MENU_HEIGHT - VIEWPORT_PADDING
|
||||
: clientY;
|
||||
|
||||
return { x: Math.max(VIEWPORT_PADDING, safeX), y: Math.max(VIEWPORT_PADDING, safeY) };
|
||||
}
|
||||
|
||||
export default function FileContextMenu({
|
||||
children,
|
||||
item,
|
||||
onRename,
|
||||
onDelete,
|
||||
onNewFile,
|
||||
onNewFolder,
|
||||
onRefresh,
|
||||
onCopyPath,
|
||||
onDownload,
|
||||
isLoading = false,
|
||||
className = '',
|
||||
}: {
|
||||
children: ReactNode;
|
||||
item?: FileContextItem | null;
|
||||
onRename?: (item: FileContextItem) => void;
|
||||
onDelete?: (item: FileContextItem) => void;
|
||||
onNewFile?: (path: string) => void;
|
||||
onNewFolder?: (path: string) => void;
|
||||
onRefresh?: () => void;
|
||||
onCopyPath?: (item: FileContextItem) => void;
|
||||
onDownload?: (item: FileContextItem) => void;
|
||||
isLoading?: boolean;
|
||||
className?: string;
|
||||
}) {
|
||||
const { t } = useTranslation();
|
||||
const [isMenuOpen, setIsMenuOpen] = useState(false);
|
||||
const [menuPosition, setMenuPosition] = useState({ x: 0, y: 0 });
|
||||
const menuRef = useRef<HTMLDivElement>(null);
|
||||
|
||||
const closeContextMenu = useCallback(() => {
|
||||
setIsMenuOpen(false);
|
||||
}, []);
|
||||
|
||||
const openContextMenuAtCursor = useCallback((event: ReactMouseEvent<HTMLDivElement>) => {
|
||||
event.preventDefault();
|
||||
event.stopPropagation();
|
||||
|
||||
setMenuPosition(calculateViewportSafePosition(event.clientX, event.clientY));
|
||||
setIsMenuOpen(true);
|
||||
}, []);
|
||||
|
||||
const runMenuActionAndClose = useCallback((action?: () => void) => {
|
||||
closeContextMenu();
|
||||
action?.();
|
||||
}, [closeContextMenu]);
|
||||
|
||||
const menuActions = useMemo<ContextMenuAction[]>(() => {
|
||||
if (item?.type === 'file') {
|
||||
return [
|
||||
{
|
||||
key: 'rename',
|
||||
icon: Pencil,
|
||||
label: t('fileTree.context.rename', 'Rename'),
|
||||
onSelect: () => onRename?.(item),
|
||||
},
|
||||
{
|
||||
key: 'delete',
|
||||
icon: Trash2,
|
||||
label: t('fileTree.context.delete', 'Delete'),
|
||||
onSelect: () => onDelete?.(item),
|
||||
isDanger: true,
|
||||
},
|
||||
{
|
||||
key: 'copyPath',
|
||||
icon: Copy,
|
||||
label: t('fileTree.context.copyPath', 'Copy Path'),
|
||||
onSelect: () => onCopyPath?.(item),
|
||||
showDividerBefore: true,
|
||||
},
|
||||
{
|
||||
key: 'download',
|
||||
icon: Download,
|
||||
label: t('fileTree.context.download', 'Download'),
|
||||
onSelect: () => onDownload?.(item),
|
||||
},
|
||||
];
|
||||
}
|
||||
|
||||
if (item?.type === 'directory') {
|
||||
return [
|
||||
{
|
||||
key: 'newFile',
|
||||
icon: FileText,
|
||||
label: t('fileTree.context.newFile', 'New File'),
|
||||
onSelect: () => onNewFile?.(item.path),
|
||||
},
|
||||
{
|
||||
key: 'newFolder',
|
||||
icon: FolderPlus,
|
||||
label: t('fileTree.context.newFolder', 'New Folder'),
|
||||
onSelect: () => onNewFolder?.(item.path),
|
||||
},
|
||||
{
|
||||
key: 'rename',
|
||||
icon: Pencil,
|
||||
label: t('fileTree.context.rename', 'Rename'),
|
||||
onSelect: () => onRename?.(item),
|
||||
showDividerBefore: true,
|
||||
},
|
||||
{
|
||||
key: 'delete',
|
||||
icon: Trash2,
|
||||
label: t('fileTree.context.delete', 'Delete'),
|
||||
onSelect: () => onDelete?.(item),
|
||||
isDanger: true,
|
||||
},
|
||||
{
|
||||
key: 'copyPath',
|
||||
icon: Copy,
|
||||
label: t('fileTree.context.copyPath', 'Copy Path'),
|
||||
onSelect: () => onCopyPath?.(item),
|
||||
showDividerBefore: true,
|
||||
},
|
||||
{
|
||||
key: 'download',
|
||||
icon: Download,
|
||||
label: t('fileTree.context.download', 'Download'),
|
||||
onSelect: () => onDownload?.(item),
|
||||
},
|
||||
];
|
||||
}
|
||||
|
||||
return [
|
||||
{
|
||||
key: 'newFile',
|
||||
icon: FileText,
|
||||
label: t('fileTree.context.newFile', 'New File'),
|
||||
onSelect: () => onNewFile?.(''),
|
||||
},
|
||||
{
|
||||
key: 'newFolder',
|
||||
icon: FolderPlus,
|
||||
label: t('fileTree.context.newFolder', 'New Folder'),
|
||||
onSelect: () => onNewFolder?.(''),
|
||||
},
|
||||
{
|
||||
key: 'refresh',
|
||||
icon: RefreshCw,
|
||||
label: t('fileTree.context.refresh', 'Refresh'),
|
||||
onSelect: onRefresh,
|
||||
showDividerBefore: true,
|
||||
},
|
||||
];
|
||||
}, [item, onCopyPath, onDelete, onDownload, onNewFile, onNewFolder, onRefresh, onRename, t]);
|
||||
|
||||
useEffect(() => {
|
||||
if (!isMenuOpen) {
|
||||
return;
|
||||
}
|
||||
|
||||
const handleOutsideMouseDown = (event: MouseEvent) => {
|
||||
const menuElement = menuRef.current;
|
||||
if (menuElement && !menuElement.contains(event.target as Node)) {
|
||||
closeContextMenu();
|
||||
}
|
||||
};
|
||||
|
||||
const handleEscapeKeyDown = (event: KeyboardEvent) => {
|
||||
if (event.key === 'Escape') {
|
||||
closeContextMenu();
|
||||
}
|
||||
};
|
||||
|
||||
document.addEventListener('mousedown', handleOutsideMouseDown);
|
||||
document.addEventListener('keydown', handleEscapeKeyDown);
|
||||
|
||||
return () => {
|
||||
document.removeEventListener('mousedown', handleOutsideMouseDown);
|
||||
document.removeEventListener('keydown', handleEscapeKeyDown);
|
||||
};
|
||||
}, [closeContextMenu, isMenuOpen]);
|
||||
|
||||
useEffect(() => {
|
||||
if (!isMenuOpen) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Arrow key support keeps the menu accessible without a mouse.
|
||||
const handleKeyboardMenuNavigation = (event: KeyboardEvent) => {
|
||||
const menuItems = menuRef.current?.querySelectorAll<HTMLElement>('[role="menuitem"]:not([disabled])');
|
||||
if (!menuItems || menuItems.length === 0) {
|
||||
return;
|
||||
}
|
||||
|
||||
const activeElement = document.activeElement as HTMLElement | null;
|
||||
const currentIndex = Array.from(menuItems).findIndex((menuItem) => menuItem === activeElement);
|
||||
|
||||
if (event.key === 'ArrowDown') {
|
||||
event.preventDefault();
|
||||
const nextIndex = currentIndex < menuItems.length - 1 ? currentIndex + 1 : 0;
|
||||
menuItems[nextIndex]?.focus();
|
||||
} else if (event.key === 'ArrowUp') {
|
||||
event.preventDefault();
|
||||
const previousIndex = currentIndex > 0 ? currentIndex - 1 : menuItems.length - 1;
|
||||
menuItems[previousIndex]?.focus();
|
||||
} else if (event.key === 'Enter' || event.key === ' ') {
|
||||
if (activeElement?.hasAttribute('role')) {
|
||||
event.preventDefault();
|
||||
activeElement.click();
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
document.addEventListener('keydown', handleKeyboardMenuNavigation);
|
||||
|
||||
return () => {
|
||||
document.removeEventListener('keydown', handleKeyboardMenuNavigation);
|
||||
};
|
||||
}, [isMenuOpen]);
|
||||
|
||||
return (
|
||||
<>
|
||||
<div onContextMenu={openContextMenuAtCursor} className={cn('contents', className)}>
|
||||
{children}
|
||||
</div>
|
||||
|
||||
{isMenuOpen && (
|
||||
<div
|
||||
ref={menuRef}
|
||||
role="menu"
|
||||
aria-label={t('fileTree.context.menuLabel', 'File context menu')}
|
||||
style={{ position: 'fixed', left: menuPosition.x, top: menuPosition.y, zIndex: 9999 }}
|
||||
className={cn(
|
||||
'min-w-[180px] py-1 px-1',
|
||||
'bg-popover border border-border rounded-lg shadow-lg',
|
||||
'animate-in fade-in-0 zoom-in-95',
|
||||
'data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95',
|
||||
)}
|
||||
>
|
||||
{isLoading ? (
|
||||
<div className="flex items-center justify-center py-4">
|
||||
<RefreshCw className="h-4 w-4 animate-spin text-muted-foreground" />
|
||||
<span className="ml-2 text-sm text-muted-foreground">{t('fileTree.context.loading', 'Loading...')}</span>
|
||||
</div>
|
||||
) : (
|
||||
menuActions.map((action) => (
|
||||
<Fragment key={action.key}>
|
||||
{action.showDividerBefore && <div className="mx-2 my-1 h-px bg-border" />}
|
||||
<button
|
||||
role="menuitem"
|
||||
tabIndex={action.isDisabled ? -1 : 0}
|
||||
disabled={isLoading || action.isDisabled}
|
||||
onClick={() => runMenuActionAndClose(action.onSelect)}
|
||||
className={cn(
|
||||
'w-full flex items-center gap-3 px-3 py-2 text-sm text-left rounded-md transition-colors',
|
||||
'focus:outline-none focus:bg-accent',
|
||||
action.isDisabled
|
||||
? 'opacity-50 cursor-not-allowed'
|
||||
: action.isDanger
|
||||
? 'text-red-600 dark:text-red-400 hover:bg-red-50 dark:hover:bg-red-950'
|
||||
: 'hover:bg-accent',
|
||||
isLoading && 'pointer-events-none',
|
||||
)}
|
||||
>
|
||||
{action.icon && <action.icon className="h-4 w-4 flex-shrink-0" />}
|
||||
<span className="flex-1">{action.label}</span>
|
||||
{action.shortcut && <span className="font-mono text-xs text-muted-foreground">{action.shortcut}</span>}
|
||||
</button>
|
||||
</Fragment>
|
||||
))
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
</>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user