fix: address CodeRabbit review comments

- Add path validation to /api/create-folder endpoint (forbidden system dirs)
- Fix repo name extraction to handle trailing slashes in URLs
- Add cleanup of partial clone directory on SSE clone failure
- Remove dead code branch (unreachable message)
- Fix Windows path separator detection in createNewFolder
- Replace alert() with setError() for consistent error handling
- Detect ssh:// URLs in addition to git@ for SSH key display
- Show create folder button for both workspace types
This commit is contained in:
Eric Blanquer​
2026-01-21 21:45:29 +01:00
parent 6726e8f44e
commit ab50c5c1a8
2 changed files with 24 additions and 5 deletions

View File

@@ -234,7 +234,8 @@ router.post('/create-workspace', async (req, res) => {
}
// Extract repo name from URL for the clone destination
const repoName = githubUrl.replace(/\.git$/, '').split('/').pop();
const normalizedUrl = githubUrl.replace(/\/+$/, '').replace(/\.git$/, '');
const repoName = normalizedUrl.split('/').pop() || 'repository';
const clonePath = path.join(absolutePath, repoName);
// Clone the repository into a subfolder
@@ -267,9 +268,7 @@ router.post('/create-workspace', async (req, res) => {
return res.json({
success: true,
project,
message: githubUrl
? 'New workspace created and repository cloned successfully'
: 'New workspace created successfully'
message: 'New workspace created successfully'
});
}
@@ -349,7 +348,8 @@ router.get('/clone-progress', async (req, res) => {
githubToken = newGithubToken;
}
const repoName = githubUrl.replace(/\.git$/, '').split('/').pop();
const normalizedUrl = githubUrl.replace(/\/+$/, '').replace(/\.git$/, '');
const repoName = normalizedUrl.split('/').pop() || 'repository';
const clonePath = path.join(absolutePath, repoName);
let cloneUrl = githubUrl;
@@ -410,6 +410,11 @@ router.get('/clone-progress', async (req, res) => {
} else if (lastError) {
errorMessage = lastError;
}
try {
await fs.rm(clonePath, { recursive: true, force: true });
} catch (cleanupError) {
console.error('Failed to clean up after clone failure:', cleanupError);
}
sendEvent('error', { message: errorMessage });
}
res.end();