Fix desktop release review findings

This commit is contained in:
Simos Mikelatos
2026-06-19 12:29:46 +00:00
parent d1930fecdb
commit d7f4d4c342
4 changed files with 7 additions and 2 deletions

View File

@@ -13,6 +13,9 @@ on:
required: false required: false
type: string type: string
permissions:
contents: read
jobs: jobs:
build-macos-semantic-helper: build-macos-semantic-helper:
strategy: strategy:

View File

@@ -156,8 +156,8 @@ function getComputerUsePermissions() {
}; };
} }
let accessibility = 'unknown'; let accessibility;
let screenRecording = 'unknown'; let screenRecording;
try { try {
accessibility = systemPreferences.isTrustedAccessibilityClient(false) ? 'granted' : 'not_granted'; accessibility = systemPreferences.isTrustedAccessibilityClient(false) ? 'granted' : 'not_granted';
} catch { } catch {

View File

@@ -86,6 +86,7 @@ async function writeServerPackageJson(stageDir) {
// The bundle stage is not a git checkout with dev dependencies, so lifecycle // The bundle stage is not a git checkout with dev dependencies, so lifecycle
// scripts such as Husky prepare must not run there. Dependency install scripts // scripts such as Husky prepare must not run there. Dependency install scripts
// still run; native modules need them before the Electron ABI rebuild below. // still run; native modules need them before the Electron ABI rebuild below.
delete stagedPackageJson.scripts.postinstall;
delete stagedPackageJson.scripts.prepare; delete stagedPackageJson.scripts.prepare;
delete stagedPackageJson.scripts.prepublishOnly; delete stagedPackageJson.scripts.prepublishOnly;
await fs.writeFile( await fs.writeFile(

View File

@@ -1,6 +1,7 @@
using System.Diagnostics; using System.Diagnostics;
using System.Drawing; using System.Drawing;
using System.Drawing.Imaging; using System.Drawing.Imaging;
using System.IO;
using System.Runtime.InteropServices; using System.Runtime.InteropServices;
using System.Text.Json; using System.Text.Json;
using System.Windows.Automation; using System.Windows.Automation;