Commit Graph

8 Commits

Author SHA1 Message Date
simosmik
ca16342a20 fix(plugins): harden input validation and scan reliability
- Validate plugin names against [a-zA-Z0-9_-] allowlist in
  manifest and asset routes to prevent path traversal via URL
- Strip embedded credentials (user:pass@) from git remote URLs
  before exposing them to the client
- Skip .tmp-* directories during scan to avoid partial installs
  from in-progress updates appearing as broken plugins
- Deduplicate plugins sharing the same manifest name to prevent
  ambiguous state
- Guard RPC proxy error handler against writing to an already-sent
  response, preventing uncaught exceptions on aborted requests
2026-03-09 07:59:46 +00:00
simosmik
c368451891 fix(plugins): support concurrent plugin updates
Replace single updatingPlugin string state with a Set to allow
multiple plugins to update simultaneously. Also disable the update
button and show a descriptive tooltip when a plugin has no git
remote configured.
2026-03-09 07:35:01 +00:00
simosmik
efdee162c9 fix(plugins): harden path traversal and respect enabled state
Use realpathSync to canonicalize paths before the plugin asset
boundary check, preventing symlink-based traversal bypasses that
could escape the plugin directory.

PluginTabContent now guards on plugin.enabled before mounting the
plugin module, and re-mounts when the enabled state changes so
toggling a plugin takes effect without a page reload.

PluginIcon safely handles a missing iconFile prop and skips
processing non-OK fetch responses instead of attempting to parse
error bodies as SVG.

Register 'plugins' as a known main tab so the settings router
preserves the tab on navigation.
2026-03-09 06:51:58 +00:00
viper151
24430fa343 fix: lint errors and deleting plugin error on windows 2026-03-06 15:44:32 +01:00
simosmik
e80fd4b09b fix(plugins): prevent git arg injection, add repo URL detection 2026-03-06 12:09:25 +00:00
simosmik
0a3e22905f fix: coderabbit changes and new plugin name & repo 2026-03-06 11:50:01 +00:00
Simos Mikelatos
6d4cea0435 Potential fix for code scanning alert no. 312: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2026-03-06 01:16:52 +01:00
Simos Mikelatos
b4169887ab feat: new plugin system 2026-03-05 22:51:27 +00:00