mirror of
https://github.com/siteboon/claudecodeui.git
synced 2026-05-01 18:28:38 +00:00
bb86236520
Restructure project creation, listing, GitHub clone progress, and TaskMaster details behind a dedicated TypeScript module under server/modules/projects/, and align the client wizard with a single path-based flow. Server / routing - Remove server/routes/projects.js and mount server/modules/projects/ projects.routes.ts at /api/projects (still behind authenticateToken). - Drop duplicate handlers from server/index.js for GET /api/projects and GET /api/projects/:projectId/taskmaster; those live on the new router. - Import WORKSPACES_ROOT and validateWorkspacePath from shared utils in index.js instead of the deleted projects route module. Projects router (projects.routes.ts) - GET /: list projects with sessions (existing snapshot behavior). - POST /create-project: validate body, reject legacy workspaceType and mixed clone fields, delegate to createProject service, return distinct success copy when an archived path is reactivated. - GET /clone-progress: Server-Sent Events for clone progress/complete/error; requires authenticated user id for token resolution; wires startCloneProject. - GET /:projectId/taskmaster: delegates to getProjectTaskMaster. Services (new) - project-management.service.ts: path validation, workspace directory creation, persistence via projectsDb.createProjectPath, mapping to API project shape; surfaces AppError for validation, conflict, and not-found cases; optional dependency injection for tests. - project-clone.service.ts: validates workspace, resolves GitHub auth (stored token or inline token), runs git clone with progress callbacks, registers project via createProject on success; sanitizes errors and supports cancellation; injectable dependencies for tests. - projects-has-taskmaster.service.ts: moves TaskMaster detection and normalization out of server/projects.js; resolve-by-id and public getProjectTaskMaster with structured AppError responses. Persistence and shared types - projectsDb.createProjectPath now returns CreateProjectPathResult (created | reactivated_archived | active_conflict) using INSERT … ON CONFLICT with selective update when the row is archived; normalizes display name from path or custom name; repository row typing moves to shared ProjectRepositoryRow. - getProjectPaths() returns only non-archived rows (isArchived = 0). - shared/types.ts: ProjectRepositoryRow, CreateProjectPathResult/outcome, WorkspacePathValidationResult. - shared/utils.ts: WORKSPACES_ROOT, forbidden path lists, validateWorkspacePath, asyncHandler for Express async routes. Legacy cleanup - server/projects.js: remove detectTaskMasterFolder, normalizeTaskMasterInfo, and getProjectTaskMasterById (logic lives in the new service). - server/routes/agent.js: register external API project paths with projectsDb.createProjectPath instead of addProjectManually try/catch; treat active_conflict as an existing registration and continue. Tests - Add Node test suites for project-management, project-clone, and projects-has-taskmaster services; update projects.service test import for renamed projects-with-sessions-fetch.service.ts. Rename - projects.service.ts → projects-with-sessions-fetch.service.ts; re-export from modules/projects/index.ts. Client (project creation wizard) - Remove StepTypeSelection and workspaceType from form state and types; wizard is two steps (configure path/GitHub auth, then review). - createWorkspaceRequest → createProjectRequest; clone vs create-only inferred from githubUrl (pathUtils / isCloneWorkflow). - Adjust step indices, WizardProgress, StepConfiguration/Review, WorkspacePathField, and src/utils/api.js as needed for the new API. Docs - Minor websocket README touch-up. Net: ~1.6k insertions / ~0.9k deletions across 29 files; behavior is centralized in typed services with explicit HTTP errors and test seams.
106 lines
3.3 KiB
TypeScript
106 lines
3.3 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import test from 'node:test';
|
|
|
|
import {
|
|
getProjectTaskMaster,
|
|
getProjectTaskMasterById,
|
|
} from '@/modules/projects/services/projects-has-taskmaster.service.js';
|
|
import { AppError } from '@/shared/utils.js';
|
|
|
|
test('getProjectTaskMasterById returns null when project path is missing', async () => {
|
|
const result = await getProjectTaskMasterById('project-1', {
|
|
resolveProjectPathById: () => null,
|
|
detectTaskMasterFolder: async () => {
|
|
throw new Error('detectTaskMasterFolder should not be called when path is missing');
|
|
},
|
|
});
|
|
|
|
assert.equal(result, null);
|
|
});
|
|
|
|
test('getProjectTaskMasterById returns configured status when taskmaster exists with essential files', async () => {
|
|
const result = await getProjectTaskMasterById('project-1', {
|
|
resolveProjectPathById: () => '/workspace/project-1',
|
|
detectTaskMasterFolder: async () => ({
|
|
hasTaskmaster: true,
|
|
hasEssentialFiles: true,
|
|
metadata: {
|
|
taskCount: 3,
|
|
subtaskCount: 0,
|
|
completed: 1,
|
|
pending: 2,
|
|
inProgress: 0,
|
|
review: 0,
|
|
completionPercentage: 33,
|
|
lastModified: '2026-01-01T00:00:00.000Z',
|
|
},
|
|
}),
|
|
});
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.projectId, 'project-1');
|
|
assert.equal(result.projectPath, '/workspace/project-1');
|
|
assert.equal(result.taskmaster.hasTaskmaster, true);
|
|
assert.equal(result.taskmaster.hasEssentialFiles, true);
|
|
assert.equal(result.taskmaster.status, 'configured');
|
|
assert.deepEqual(result.taskmaster.metadata, {
|
|
taskCount: 3,
|
|
subtaskCount: 0,
|
|
completed: 1,
|
|
pending: 2,
|
|
inProgress: 0,
|
|
review: 0,
|
|
completionPercentage: 33,
|
|
lastModified: '2026-01-01T00:00:00.000Z',
|
|
});
|
|
});
|
|
|
|
test('getProjectTaskMasterById returns not-configured status when taskmaster is missing', async () => {
|
|
const result = await getProjectTaskMasterById('project-1', {
|
|
resolveProjectPathById: () => '/workspace/project-1',
|
|
detectTaskMasterFolder: async () => ({
|
|
hasTaskmaster: false,
|
|
}),
|
|
});
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.taskmaster.hasTaskmaster, false);
|
|
assert.equal(result.taskmaster.hasEssentialFiles, false);
|
|
assert.equal(result.taskmaster.status, 'not-configured');
|
|
assert.equal(result.taskmaster.metadata, null);
|
|
});
|
|
|
|
test('getProjectTaskMaster throws when project id is missing', async () => {
|
|
await assert.rejects(
|
|
async () =>
|
|
getProjectTaskMaster('', async () => ({
|
|
projectId: 'project-1',
|
|
projectPath: '/workspace/project-1',
|
|
taskmaster: {
|
|
hasTaskmaster: true,
|
|
hasEssentialFiles: true,
|
|
metadata: null,
|
|
status: 'configured',
|
|
},
|
|
})),
|
|
(error: unknown) => {
|
|
assert.ok(error instanceof AppError);
|
|
assert.equal(error.code, 'PROJECT_ID_REQUIRED');
|
|
assert.equal(error.statusCode, 400);
|
|
return true;
|
|
},
|
|
);
|
|
});
|
|
|
|
test('getProjectTaskMaster throws when project does not exist', async () => {
|
|
await assert.rejects(
|
|
async () => getProjectTaskMaster('project-that-does-not-exist', async () => null),
|
|
(error: unknown) => {
|
|
assert.ok(error instanceof AppError);
|
|
assert.equal(error.code, 'PROJECT_NOT_FOUND');
|
|
assert.equal(error.statusCode, 404);
|
|
return true;
|
|
},
|
|
);
|
|
});
|