mirror of
https://github.com/siteboon/claudecodeui.git
synced 2026-06-24 02:45:49 +08:00
* feat(skills): add provider skill management Users need one settings surface to discover and install skills without manually navigating provider-specific directories. Add provider-backed global skill installation for Claude, Codex, Gemini, and Cursor, while keeping OpenCode read-only because it reuses other providers' skill locations. Add a responsive Skills settings tab with scoped discovery, search, refresh controls, markdown and folder uploads, upload feedback, and overflow-safe layouts. Validate bundled skill files and paths before writing them, preserve scripts and assets, and cover provider discovery and installation behavior with tests. * fix(skills): preserve uploaded skill folders Folder drops discarded supporting scripts and assets. Keep relative paths and upload every file from the selected skill folder. Use the selected folder name for installation and cover it in provider tests. * fix(skills): restrict standalone skill uploads Only show Markdown files when selecting standalone skills. Normalize browser file paths so SKILL.md is not mistaken for a folder named dot. * fix(skills): validate installs before writing Preserve bundled files and normalize fallback names across skill installation paths. Validate complete batches before writing and reject existing targets to avoid partial installs. Keep project metadata and make folder selection tolerant of casing and cancelled dialogs. * fix(skills): overwrite existing installations Replace an existing skill directory instead of rejecting a duplicate installation. Remove stale supporting files so the installed directory exactly matches the new upload.
245 lines
8.2 KiB
TypeScript
245 lines
8.2 KiB
TypeScript
import path from 'node:path';
|
|
import { mkdir, rm, writeFile } from 'node:fs/promises';
|
|
|
|
import type { IProviderSkills } from '@/shared/interfaces.js';
|
|
import type {
|
|
LLMProvider,
|
|
ProviderSkillCreateInput,
|
|
ProviderSkill,
|
|
ProviderSkillListOptions,
|
|
ProviderSkillSource,
|
|
} from '@/shared/types.js';
|
|
import {
|
|
findProviderSkillMarkdownFiles,
|
|
readOptionalString,
|
|
readProviderSkillMarkdownDefinitionFromContent,
|
|
readProviderSkillMarkdownDefinition,
|
|
AppError,
|
|
} from '@/shared/utils.js';
|
|
|
|
const resolveWorkspacePath = (workspacePath?: string): string =>
|
|
path.resolve(workspacePath ?? process.cwd());
|
|
|
|
const stripMarkdownExtension = (value: string): string => value.replace(/\.md$/i, '');
|
|
|
|
const normalizeSkillDirectoryName = (value: string): string => (
|
|
value
|
|
.trim()
|
|
.replace(/[\\/]+/g, '-')
|
|
.replace(/[<>:"|?*\x00-\x1F]/g, '-')
|
|
.replace(/\s+/g, '-')
|
|
.replace(/-+/g, '-')
|
|
.replace(/^\.+|\.+$/g, '')
|
|
.replace(/^-+|-+$/g, '')
|
|
);
|
|
|
|
type PendingSkillInstall = {
|
|
skillDirectoryPath: string;
|
|
skillPath: string;
|
|
content: string;
|
|
supportingFiles: Array<{
|
|
targetPath: string;
|
|
content: string | Buffer;
|
|
}>;
|
|
skill: ProviderSkill;
|
|
};
|
|
|
|
const resolveSkillSupportingFilePath = (
|
|
skillDirectoryPath: string,
|
|
relativePath: string,
|
|
entryIndex: number,
|
|
): string => {
|
|
const normalizedRelativePath = relativePath.trim().replace(/\\/g, '/');
|
|
const pathSegments = normalizedRelativePath.split('/');
|
|
if (
|
|
!normalizedRelativePath
|
|
|| path.isAbsolute(normalizedRelativePath)
|
|
|| pathSegments.some((segment) => !segment || segment === '.' || segment === '..')
|
|
|| normalizedRelativePath.toLowerCase() === 'skill.md'
|
|
) {
|
|
throw new AppError(
|
|
`Skill entry ${entryIndex + 1} includes an invalid supporting file path "${relativePath}".`,
|
|
{
|
|
code: 'PROVIDER_SKILL_FILE_PATH_INVALID',
|
|
statusCode: 400,
|
|
},
|
|
);
|
|
}
|
|
|
|
const resolvedSkillDirectoryPath = path.resolve(skillDirectoryPath);
|
|
const resolvedFilePath = path.resolve(resolvedSkillDirectoryPath, ...pathSegments);
|
|
if (!resolvedFilePath.startsWith(`${resolvedSkillDirectoryPath}${path.sep}`)) {
|
|
throw new AppError(
|
|
`Skill entry ${entryIndex + 1} supporting files must stay inside the skill directory.`,
|
|
{
|
|
code: 'PROVIDER_SKILL_FILE_PATH_INVALID',
|
|
statusCode: 400,
|
|
},
|
|
);
|
|
}
|
|
|
|
return resolvedFilePath;
|
|
};
|
|
|
|
/**
|
|
* Shared skills provider for provider-specific skill source discovery.
|
|
*/
|
|
export abstract class SkillsProvider implements IProviderSkills {
|
|
protected readonly provider: LLMProvider;
|
|
|
|
protected constructor(provider: LLMProvider) {
|
|
this.provider = provider;
|
|
}
|
|
|
|
async listSkills(options?: ProviderSkillListOptions): Promise<ProviderSkill[]> {
|
|
const workspacePath = resolveWorkspacePath(options?.workspacePath);
|
|
const sources = await this.getSkillSources(workspacePath);
|
|
const skills: ProviderSkill[] = [];
|
|
|
|
for (const source of sources) {
|
|
const skillFiles = await findProviderSkillMarkdownFiles(source.rootDir, {
|
|
recursive: source.recursive,
|
|
});
|
|
for (const skillPath of skillFiles) {
|
|
try {
|
|
const definition = await readProviderSkillMarkdownDefinition(skillPath);
|
|
const command = source.commandForSkill
|
|
? source.commandForSkill(definition.name)
|
|
: `${source.commandPrefix ?? '/'}${definition.name}`;
|
|
|
|
skills.push({
|
|
provider: this.provider,
|
|
name: definition.name,
|
|
description: definition.description,
|
|
command,
|
|
scope: source.scope,
|
|
sourcePath: skillPath,
|
|
pluginName: source.pluginName,
|
|
pluginId: source.pluginId,
|
|
});
|
|
} catch {
|
|
// A malformed or unreadable skill markdown file should not hide other valid skills.
|
|
}
|
|
}
|
|
}
|
|
|
|
return skills;
|
|
}
|
|
|
|
async addSkills(input: ProviderSkillCreateInput): Promise<ProviderSkill[]> {
|
|
const globalSkillSource = await this.getGlobalSkillSource();
|
|
if (!globalSkillSource) {
|
|
throw new AppError(`${this.provider} does not support managed global skills.`, {
|
|
code: 'PROVIDER_SKILLS_WRITE_UNSUPPORTED',
|
|
statusCode: 400,
|
|
});
|
|
}
|
|
|
|
if (!Array.isArray(input.entries) || input.entries.length === 0) {
|
|
throw new AppError('At least one skill entry is required.', {
|
|
code: 'PROVIDER_SKILLS_REQUIRED',
|
|
statusCode: 400,
|
|
});
|
|
}
|
|
|
|
const seenSkillPaths = new Set<string>();
|
|
const pendingInstalls: PendingSkillInstall[] = [];
|
|
|
|
for (const [index, entry] of input.entries.entries()) {
|
|
const content = typeof entry.content === 'string' ? entry.content.trim() : '';
|
|
if (!content) {
|
|
throw new AppError(`Skill entry ${index + 1} must include markdown content.`, {
|
|
code: 'PROVIDER_SKILL_CONTENT_REQUIRED',
|
|
statusCode: 400,
|
|
});
|
|
}
|
|
|
|
const fileNameFallback = readOptionalString(entry.fileName);
|
|
const requestedDirectoryName = readOptionalString(entry.directoryName);
|
|
const fallbackSkillName = normalizeSkillDirectoryName(
|
|
requestedDirectoryName
|
|
?? (fileNameFallback ? stripMarkdownExtension(fileNameFallback) : `skill-${index + 1}`),
|
|
);
|
|
const definition = readProviderSkillMarkdownDefinitionFromContent(content, fallbackSkillName);
|
|
const resolvedDirectoryName = normalizeSkillDirectoryName(
|
|
requestedDirectoryName ?? definition.name,
|
|
);
|
|
|
|
if (!resolvedDirectoryName) {
|
|
throw new AppError(`Skill entry ${index + 1} must include a valid skill name.`, {
|
|
code: 'PROVIDER_SKILL_NAME_REQUIRED',
|
|
statusCode: 400,
|
|
});
|
|
}
|
|
|
|
const skillDirectoryPath = path.join(globalSkillSource.rootDir, resolvedDirectoryName);
|
|
const skillPath = path.join(skillDirectoryPath, 'SKILL.md');
|
|
const normalizedSkillPath = path.resolve(skillPath);
|
|
if (seenSkillPaths.has(normalizedSkillPath)) {
|
|
throw new AppError(`Duplicate skill target "${resolvedDirectoryName}" in one request.`, {
|
|
code: 'PROVIDER_SKILL_DUPLICATE_TARGET',
|
|
statusCode: 400,
|
|
});
|
|
}
|
|
|
|
seenSkillPaths.add(normalizedSkillPath);
|
|
const supportingFiles = (entry.files ?? []).map((file) => ({
|
|
targetPath: resolveSkillSupportingFilePath(skillDirectoryPath, file.relativePath, index),
|
|
content: file.encoding === 'base64'
|
|
? Buffer.from(file.content, 'base64')
|
|
: file.content,
|
|
}));
|
|
const seenSupportingPaths = new Set<string>();
|
|
for (const file of supportingFiles) {
|
|
if (seenSupportingPaths.has(file.targetPath)) {
|
|
throw new AppError(`Skill entry ${index + 1} includes a duplicate supporting file path.`, {
|
|
code: 'PROVIDER_SKILL_DUPLICATE_FILE',
|
|
statusCode: 400,
|
|
});
|
|
}
|
|
seenSupportingPaths.add(file.targetPath);
|
|
}
|
|
|
|
const command = globalSkillSource.commandForSkill
|
|
? globalSkillSource.commandForSkill(definition.name)
|
|
: `${globalSkillSource.commandPrefix ?? '/'}${definition.name}`;
|
|
|
|
pendingInstalls.push({
|
|
skillDirectoryPath,
|
|
skillPath,
|
|
content,
|
|
supportingFiles,
|
|
skill: {
|
|
provider: this.provider,
|
|
name: definition.name,
|
|
description: definition.description,
|
|
command,
|
|
scope: globalSkillSource.scope,
|
|
sourcePath: skillPath,
|
|
pluginName: globalSkillSource.pluginName,
|
|
pluginId: globalSkillSource.pluginId,
|
|
},
|
|
});
|
|
}
|
|
|
|
for (const install of pendingInstalls) {
|
|
// Replace the complete skill directory so removed scripts or assets do not remain stale.
|
|
await rm(install.skillDirectoryPath, { recursive: true, force: true });
|
|
await mkdir(install.skillDirectoryPath, { recursive: true });
|
|
await writeFile(install.skillPath, `${install.content}\n`, 'utf8');
|
|
for (const file of install.supportingFiles) {
|
|
await mkdir(path.dirname(file.targetPath), { recursive: true });
|
|
await writeFile(file.targetPath, file.content);
|
|
}
|
|
}
|
|
|
|
return pendingInstalls.map((install) => install.skill);
|
|
}
|
|
|
|
protected abstract getSkillSources(workspacePath: string): Promise<ProviderSkillSource[]>;
|
|
|
|
protected async getGlobalSkillSource(): Promise<ProviderSkillSource | null> {
|
|
return null;
|
|
}
|
|
}
|