mirror of
https://github.com/siteboon/claudecodeui.git
synced 2026-06-05 20:45:45 +08:00
The WebSocket gateway never sent ping frames, so any reverse proxy with an idle timeout (Cloudflare Tunnel ~100s, AWS ALB 60s, nginx 60s, etc.) would silently tear down /shell, /ws and /plugin-ws/* connections after the idle window. The UI reconnects automatically but users see a "Connecting to shell" toast every 1–3 minutes during normal use and any in-flight PTY/chat traffic can race the reconnect. Schedule a 30s ws.ping() per connection at the gateway level, cleared on close/error. ping/pong counts as protocol activity for all proxies that implement WebSocket correctly, so this single change covers every deployment topology without per-proxy tuning. Fixes #769 Co-authored-by: Haile <118998054+blackmammoth@users.noreply.github.com>
77 lines
2.7 KiB
TypeScript
77 lines
2.7 KiB
TypeScript
import type { Server as HttpServer } from 'node:http';
|
|
|
|
import { WebSocketServer, type VerifyClientCallbackSync } from 'ws';
|
|
|
|
import { handleChatConnection } from '@/modules/websocket/services/chat-websocket.service.js';
|
|
import { verifyWebSocketClient } from '@/modules/websocket/services/websocket-auth.service.js';
|
|
import { handlePluginWsProxy } from '@/modules/websocket/services/plugin-websocket-proxy.service.js';
|
|
import { handleShellConnection } from '@/modules/websocket/services/shell-websocket.service.js';
|
|
import type { AuthenticatedWebSocketRequest } from '@/shared/types.js';
|
|
|
|
type WebSocketServerDependencies = {
|
|
verifyClient: Parameters<typeof verifyWebSocketClient>[1];
|
|
chat: Parameters<typeof handleChatConnection>[2];
|
|
shell: Parameters<typeof handleShellConnection>[1];
|
|
getPluginPort: Parameters<typeof handlePluginWsProxy>[2];
|
|
};
|
|
|
|
/**
|
|
* Creates and wires the server-wide websocket gateway used for chat, shell, and
|
|
* plugin proxy routes.
|
|
*/
|
|
export function createWebSocketServer(
|
|
server: HttpServer,
|
|
dependencies: WebSocketServerDependencies
|
|
): WebSocketServer {
|
|
const wss = new WebSocketServer({
|
|
server,
|
|
verifyClient: ((
|
|
info: Parameters<VerifyClientCallbackSync<AuthenticatedWebSocketRequest>>[0]
|
|
) => verifyWebSocketClient(info, dependencies.verifyClient)),
|
|
});
|
|
|
|
wss.on('connection', (ws, request) => {
|
|
// Keep WebSocket alive across reverse-proxy idle timeouts (Cloudflare ~100s,
|
|
// AWS ALB 60s, nginx 60s, etc.). Without app-level pings these connections
|
|
// are silently torn down even when the UI is active, causing repeated
|
|
// reconnect cycles. ws library heartbeat is opt-in.
|
|
const HEARTBEAT_INTERVAL_MS = 30_000;
|
|
const heartbeat = setInterval(() => {
|
|
if (ws.readyState === ws.OPEN) {
|
|
try {
|
|
ws.ping();
|
|
} catch {
|
|
// socket may have been closed concurrently — interval will be cleared below
|
|
}
|
|
}
|
|
}, HEARTBEAT_INTERVAL_MS);
|
|
const stopHeartbeat = () => clearInterval(heartbeat);
|
|
ws.on('close', stopHeartbeat);
|
|
ws.on('error', stopHeartbeat);
|
|
|
|
const incomingRequest = request as AuthenticatedWebSocketRequest;
|
|
const url = incomingRequest.url ?? '/';
|
|
const pathname = new URL(url, 'http://localhost').pathname;
|
|
|
|
if (pathname === '/shell') {
|
|
handleShellConnection(ws, dependencies.shell);
|
|
return;
|
|
}
|
|
|
|
if (pathname === '/ws') {
|
|
handleChatConnection(ws, incomingRequest, dependencies.chat);
|
|
return;
|
|
}
|
|
|
|
if (pathname.startsWith('/plugin-ws/')) {
|
|
handlePluginWsProxy(ws, pathname, dependencies.getPluginPort);
|
|
return;
|
|
}
|
|
|
|
console.log('[WARN] Unknown WebSocket path:', pathname);
|
|
ws.close();
|
|
});
|
|
|
|
return wss;
|
|
}
|