d8dfun/virtual-kubelet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

lifecycle test: timeout send goroutine on context

Browse Source 
In error cases these goroutines never exit.
Trying to debug cases we end up with a bunch of these goroutines stuck
making it difficult to troubleshoot.

We could just make a buffered channel, however this will makes it less
clear, in cases of an error, what all is happening.
This commit is contained in:
Brian Goff
2021-05-18 21:33:09 +00:00
parent 4fe8496dd1
commit 0543245668
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
node/lifecycle_test.go
View File

@@ -367,6 +367,14 @@ func testDanglingPodScenario(ctx context.Context, t *testing.T, s *system, m tes
} }
func sendErr(ctx context.Context, ch chan error, err error) {
select {
case <-ctx.Done():
log.G(ctx).WithError(err).Warn("timeout waiting to send test error")
case ch <- err:
}
}
func testDanglingPodScenarioWithDeletionTimestamp(ctx context.Context, t *testing.T, s *system, m testingProvider) { func testDanglingPodScenarioWithDeletionTimestamp(ctx context.Context, t *testing.T, s *system, m testingProvider) {
t.Parallel() t.Parallel()
@@ -396,7 +404,7 @@ func testDanglingPodScenarioWithDeletionTimestamp(ctx context.Context, t *testin
func(ev watch.Event) (bool, error) { func(ev watch.Event) (bool, error) {
return ev.Type == watch.Deleted, nil return ev.Type == watch.Deleted, nil
}) })
watchErrCh <- watchErr sendErr(ctx, watchErrCh, watchErr)
}() }()
// Start the pod controller // Start the pod controller
@@ -436,7 +444,7 @@ func testCreateStartDeleteScenario(ctx context.Context, t *testing.T, s *system,
return pod.Name == p.ObjectMeta.Name, nil return pod.Name == p.ObjectMeta.Name, nil
}) })
watchErrCh <- watchErr sendErr(ctx, watchErrCh, watchErr)
}() }()
// Create the Pod // Create the Pod
@@ -465,7 +473,7 @@ func testCreateStartDeleteScenario(ctx context.Context, t *testing.T, s *system,
return pod.Status.Phase == corev1.PodRunning, nil return pod.Status.Phase == corev1.PodRunning, nil
}) })
watchErrCh <- watchErr sendErr(ctx, watchErrCh, watchErr)
}() }()
assert.NilError(t, s.start(ctx)) assert.NilError(t, s.start(ctx))
@@ -487,7 +495,7 @@ func testCreateStartDeleteScenario(ctx context.Context, t *testing.T, s *system,
_, watchDeleteErr := watchutils.UntilWithoutRetry(ctx, watcher2, func(ev watch.Event) (bool, error) { _, watchDeleteErr := watchutils.UntilWithoutRetry(ctx, watcher2, func(ev watch.Event) (bool, error) {
return ev.Type == watch.Deleted, nil return ev.Type == watch.Deleted, nil
}) })
waitDeleteCh <- watchDeleteErr sendErr(ctx, waitDeleteCh, watchDeleteErr)
}() }()
// Setup a watch prior to pod deletion // Setup a watch prior to pod deletion
@@ -495,7 +503,7 @@ func testCreateStartDeleteScenario(ctx context.Context, t *testing.T, s *system,
assert.NilError(t, err) assert.NilError(t, err)
defer watcher.Stop() defer watcher.Stop()
go func() { go func() {
watchErrCh <- waitFunction(ctx, watcher) sendErr(ctx, watchErrCh, waitFunction(ctx, watcher))
}() }()
// Delete the pod via deletiontimestamp // Delete the pod via deletiontimestamp
@@ -559,7 +567,7 @@ func testUpdatePodWhileRunningScenario(ctx context.Context, t *testing.T, s *sys
}) })
// This deepcopy is required to please the race detector // This deepcopy is required to please the race detector
p = newPod.Object.(*corev1.Pod).DeepCopy() p = newPod.Object.(*corev1.Pod).DeepCopy()
watchErrCh <- watchErr sendErr(ctx, watchErrCh, watchErr)
}() }()
// Start the pod controller // Start the pod controller