From 09ad3fe64447996c04e990ca7de122a1795f7f81 Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Tue, 24 Aug 2021 18:49:42 +0000 Subject: [PATCH] Return early on ping error Found that this caused a panic after many many test runs. It seems like we should have returned early since the pingResult is nil. We don't want to update a lease when ping fails. --- node/lease_controller_v1.go | 1 + 1 file changed, 1 insertion(+) diff --git a/node/lease_controller_v1.go b/node/lease_controller_v1.go index aba55910f..3d57e8b27 100644 --- a/node/lease_controller_v1.go +++ b/node/lease_controller_v1.go @@ -114,6 +114,7 @@ func (c *leaseController) sync(ctx context.Context) { pingResult, err := c.nodeController.nodePingController.getResult(ctx) if err != nil { log.G(ctx).WithError(err).Error("Could not get ping status") + return } if pingResult.error != nil { log.G(ctx).WithError(pingResult.error).Error("Ping result is not clean, not updating lease")