Address concerns with PR

Also, just use Kubernetes waiter library.
This commit is contained in:
Sargun Dhillon
2020-07-14 18:46:22 -07:00
parent 12625131b5
commit 1e9e055e89
2 changed files with 43 additions and 23 deletions

View File

@@ -83,8 +83,8 @@ type PodNotifier interface {
// fashion. The provided pod's PodStatus should be up to date when
// this function is called.
//
// NotifyPods may block callers. The NotifyPods function may be called
// concurrently.
// NotifyPods must not block the caller since it is only used to register the callback.
// The callback passed into `NotifyPods` may block when called.
NotifyPods(context.Context, func(*corev1.Pod))
}