d8dfun/virtual-kubelet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Prometheus metrics are encoded as text, not JSON (#1101)

Browse Source 
Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com>
This commit is contained in:
fnuarnav
2023-04-06 00:03:43 -07:00
committed by GitHub
parent 9c32bfb0ae
commit 2c155accb7
7 changed files with 207 additions and 286 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/test/e2e/framework/stats.go
View File

@@ -4,7 +4,6 @@ import (
"context"
"encoding/json"
dto "github.com/prometheus/client_model/go"
api "github.com/virtual-kubelet/virtual-kubelet/node/api"
stats "github.com/virtual-kubelet/virtual-kubelet/node/api/statsv1alpha1"
"k8s.io/apimachinery/pkg/util/net"
@@ -33,7 +32,7 @@ func (f *Framework) GetStatsSummary(ctx context.Context) (*stats.Summary, error)
}
// GetStatsSummary queries the /metrics/resource endpoint of the virtual-kubelet and returns the Summary object obtained as a response.
func (f *Framework) GetMetricsResource(ctx context.Context) ([]*dto.MetricFamily, error) {
func (f *Framework) GetMetricsResource(ctx context.Context) ([]byte, error) {
// Query the /stats/summary endpoint.
b, err := f.KubeClient.CoreV1().
RESTClient().
@@ -46,11 +45,6 @@ func (f *Framework) GetMetricsResource(ctx context.Context) ([]*dto.MetricFamily
if err != nil {
return nil, err
}
// Unmarshal the response as a MetricFamily object and return it.
res := []*dto.MetricFamily{}
err = json.Unmarshal(b, &res)
if err != nil {
return nil, err
}
return res, nil
return b, nil
}