d8dfun/virtual-kubelet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Add a little bit of documentation to NotifyPods

Browse Source 
As far as I can tell, based on the implementation in MockProvider
NotifyPods is called with the mutated pod. This allows us to
take a copy of the Pod object in NotifyPods, and make it so
(eventually) we don't need to do a callback to GetPodStatus.
This commit is contained in:
Sargun Dhillon
2019-07-25 08:41:12 -07:00
parent d0c91a1933
commit 3efc9229ba
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
node/podcontroller.go
View File

@@ -69,9 +69,13 @@ type PodLifecycleHandler interface {
// of pod status updates asynchronously. // of pod status updates asynchronously.
type PodNotifier interface { type PodNotifier interface {
// NotifyPods instructs the notifier to call the passed in function when // NotifyPods instructs the notifier to call the passed in function when
// the pod status changes. // the pod status changes. It should be called when a pod's status changes.
// //
// NotifyPods should not block callers. // The provided pointer to a Pod is guaranteed to be used in a read-only
// fashion. The provided pod's PodStatus should be up to date when
// this function is called.
//
// NotifyPods will not block callers.
NotifyPods(context.Context, func(*corev1.Pod)) NotifyPods(context.Context, func(*corev1.Pod))
} }