From 5f64eab10936853a1207d4208a0e62a1b49b6318 Mon Sep 17 00:00:00 2001 From: Sargun Dhillon Date: Mon, 22 Jun 2020 22:53:27 -0700 Subject: [PATCH] Fix kubernetes version dependency checking script We had locked to version v1.17.6 when this script was released. At the time, it was also the current stable release, and what was presented by the github API. It turns out the Github API does not present all tags. This changes it to fetch the annotated tag from the upstream repo. --- scripts/validate/check_version.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/validate/check_version.sh b/scripts/validate/check_version.sh index e76647c58..16bb4de65 100755 --- a/scripts/validate/check_version.sh +++ b/scripts/validate/check_version.sh @@ -12,7 +12,8 @@ fi echo "Found kubernetes version: ${kubeversion}" -readonly sha=$(curl http://api.github.com/repos/kubernetes/kubernetes/tags -L -s |jq -r --arg kubeversion "${kubeversion}" '.[] |select (.name==$kubeversion) | .commit.sha') +# We postfix the tag to search for with ^{}, as we want the annotated tag +readonly sha=$(git ls-remote --tags git@github.com:kubernetes/kubernetes.git "${kubeversion}^{}"|cut -f1 -d$'\t') if [[ ! "${sha}" =~ ^[0-9a-f]{40}$ ]]; then echo "Kube Sha: ${sha} in unexpected format"