From 1a2c0bb029fb76dc0750db57b06633940c5fde8f Mon Sep 17 00:00:00 2001
From: Sargun Dhillon <sargun@sargun.me>
Date: Mon, 16 Nov 2020 11:11:52 -0800
Subject: [PATCH] Do not export KUBEBUILDER_ASSETS variable

This sets KUBEBUILDERA_ASSETS only for envtest. No need to leak
the variable throughout the tests. In addition, it makes it easier
to figure out how to run the tests yourself on command line.
---
 Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 51ac91401..2f56be13f 100644
--- a/Makefile
+++ b/Makefile
@@ -26,7 +26,6 @@ IGNORED_PACKAGES := /vendor/
 
 TEST_OS := $(shell go env GOOS)
 TEST_ARCH := $(shell go env GOARCH)
-export KUBEBUILDER_ASSETS := $(PWD)/kubebuilder_2.3.1_${TEST_OS}_${TEST_ARCH}/bin
 
 .PHONY: all
 all: test build
@@ -188,7 +187,7 @@ kubebuilder_2.3.1_${TEST_OS}_${TEST_ARCH}: kubebuilder_2.3.1_${TEST_OS}_${TEST_A
 envtest: kubebuilder_2.3.1_${TEST_OS}_${TEST_ARCH}
 	# You can add klog flags for debugging, like: -klog.v=10 -klog.logtostderr
 	# klogv2 flags just wraps our existing logrus.
-	go test -v ./internal/test/vk_envtest -envtest=true
+	KUBEBUILDER_ASSETS=$(PWD)/kubebuilder_2.3.1_${TEST_OS}_${TEST_ARCH}/bin go test -v ./internal/test/vk_envtest -envtest=true
 
 .PHONY: fmt
 fmt: