From 966c76368f10931cd4ff591b629ceb7000fb099a Mon Sep 17 00:00:00 2001 From: robbiezhang Date: Thu, 18 Oct 2018 20:06:03 +0000 Subject: [PATCH] user %T instead of reflect.TypeOf --- vkubelet/pod.go | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/vkubelet/pod.go b/vkubelet/pod.go index a57d0a19a..f7c26f82a 100644 --- a/vkubelet/pod.go +++ b/vkubelet/pod.go @@ -3,7 +3,6 @@ package vkubelet import ( "context" "fmt" - "reflect" "time" pkgerrors "github.com/pkg/errors" @@ -33,8 +32,8 @@ func (s *Server) onAddPod(ctx context.Context, obj interface{}) { pod, ok := obj.(*corev1.Pod) if !ok { - span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) - logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) + span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)}) + logger.Errorf("obj is not of a valid type: %T", obj) return } @@ -55,8 +54,8 @@ func (s *Server) onUpdatePod(ctx context.Context, obj interface{}) { pod, ok := obj.(*corev1.Pod) if !ok { - span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) - logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) + span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)}) + logger.Errorf("obj is not of a valid type: %T", obj) return } @@ -79,14 +78,14 @@ func (s *Server) onDeletePod(ctx context.Context, obj interface{}) { if !ok { delta, ok := obj.(cache.DeletedFinalStateUnknown) if !ok { - span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) - logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) + span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)}) + logger.Errorf("obj is not of a valid type: %T", obj) return } if pod, ok = delta.Obj.(*corev1.Pod); !ok { - span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) - logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) + span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)}) + logger.Errorf("obj is not of a valid type: %T", obj) return } }