From a1f46e7f04d72670da0cc7c904c3a39ea0733645 Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Fri, 3 Aug 2018 10:41:55 -0700 Subject: [PATCH 1/2] Validate deps in CI --- .circleci/config.yml | 2 +- scripts/validate/dep.sh | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100755 scripts/validate/dep.sh diff --git a/.circleci/config.yml b/.circleci/config.yml index 47047e282..183f9bee0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -17,7 +17,7 @@ jobs: echo 'export KUBECONFIG=${outputPathKubeConfigFile}' >> $BASH_ENV - run: name: Dependencies - command: go get -v -t -d ./... + command: scripts/validate/dep.sh - run: name: Build command: V=1 make build diff --git a/scripts/validate/dep.sh b/scripts/validate/dep.sh new file mode 100755 index 000000000..ab03f5063 --- /dev/null +++ b/scripts/validate/dep.sh @@ -0,0 +1,16 @@ + +validate_dep() { + dep ensure + nChanges=$(git status --porcelain -u | wc -l) + [ $nChanges -eq 0 ] +} + + +validate_dep || { + ret=$? + echo '`dep ensure` was not run. Make sure dependency changes are committed to the repository.' + echo 'You may also need to check that all deps are pinned to a commit or tag instead of a branch or HEAD.' + echo 'Check Gopkg.toml and Gopkg.lock' + git diff Gopkg.toml Gopkg.lock + exit $ret +} \ No newline at end of file From 7e7947cd3dfd946f2d0f1c92a8500190bfd6cbdb Mon Sep 17 00:00:00 2001 From: Deep Kapur Date: Fri, 3 Aug 2018 15:13:36 -0700 Subject: [PATCH 2/2] fixing a minor typo (#290) * fixing a minor typo * Update README.md --- providers/sfmesh/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/providers/sfmesh/README.md b/providers/sfmesh/README.md index df6c3e699..2549dc2ed 100644 --- a/providers/sfmesh/README.md +++ b/providers/sfmesh/README.md @@ -1,12 +1,12 @@ # Kubernetes Virtual Kubelet with Service Fabric Mesh -[Service Fabric Mesh](https://docs.microsoft.com/en-us/azure/service-fabric-mesh/service-fabric-mesh-overview) is a fully managed service that enables developers to deploy microservices applications without managing virtual machines, storage, or networking. Applications hosted on Service Fabric Mesh run and scale without you worrying about the infrastructure powering it. +[Service Fabric Mesh](https://docs.microsoft.com/en-us/azure/service-fabric-mesh/service-fabric-mesh-overview) is a fully managed service that enables developers to deploy microservices applications without managing virtual machines, storage, or networking. Applications hosted on Service Fabric Mesh run and scale without you worrying about the infrastructure powering them. The Virtual kubelet integration allows you to use the Kubernetes API to burst out compute to a Service Fabric Mesh cluster and schedule pods as Mesh Applications. ## Status: Experimental -This provider is currently in the exterimental stages. Contributions welcome! +This provider is currently in the experimental stages. Contributions are welcome! ## Setup