diff --git a/log/klogv2/klogv2.go b/log/klogv2/klogv2.go index 298abaa91..57bfac83c 100644 --- a/log/klogv2/klogv2.go +++ b/log/klogv2/klogv2.go @@ -26,6 +26,9 @@ import ( "k8s.io/klog/v2" ) +// Ensure log.Logger is fully implemented during compile time. +var _ log.Logger = (*adapter)(nil) + // adapter implements the `log.Logger` interface for klogv2 type adapter struct { fields map[string]interface{} diff --git a/log/klogv2/klogv2_test.go b/log/klogv2/klogv2_test.go deleted file mode 100644 index d150ae850..000000000 --- a/log/klogv2/klogv2_test.go +++ /dev/null @@ -1,28 +0,0 @@ -// Copyright © 2021 The virtual-kubelet authors -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. -package klogv2 - -import ( - "testing" - - "github.com/virtual-kubelet/virtual-kubelet/log" -) - -func TestImplementsLoggerInterface(t *testing.T) { - l := FromKlogv2(nil) - - if _, ok := l.(log.Logger); !ok { - t.Fatal("does not implement log.Logger interface") - } -} diff --git a/log/logrus/logrus.go b/log/logrus/logrus.go index e208905cb..31974604a 100644 --- a/log/logrus/logrus.go +++ b/log/logrus/logrus.go @@ -22,6 +22,9 @@ import ( "github.com/virtual-kubelet/virtual-kubelet/log" ) +// Ensure log.Logger is fully implemented during compile time. +var _ log.Logger = (*adapter)(nil) + // adapter implements the `log.Logger` interface for logrus type adapter struct { *logrus.Entry diff --git a/log/logrus/logrus_test.go b/log/logrus/logrus_test.go deleted file mode 100644 index f51667108..000000000 --- a/log/logrus/logrus_test.go +++ /dev/null @@ -1,30 +0,0 @@ -// Copyright © 2017 The virtual-kubelet authors -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package logrus - -import ( - "testing" - - "github.com/sirupsen/logrus" - "github.com/virtual-kubelet/virtual-kubelet/log" -) - -func TestImplementsLoggerInterface(t *testing.T) { - l := FromLogrus(&logrus.Entry{}) - - if _, ok := l.(log.Logger); !ok { - t.Fatal("does not implement log.Logger interface") - } -}