d8dfun/virtual-kubelet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Add nolintlint to warn us of extraneous nolint comments

Browse Source
This commit is contained in:
Sargun Dhillon
2020-12-04 21:21:31 -08:00
parent bbe4551940
commit c0d5809285
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.golangci.yml
View File

@@ -14,6 +14,7 @@ linters:
- varcheck - varcheck
- deadcode - deadcode
- misspell - misspell
- nolintlint
issues: issues:
exclude-use-default: false exclude-use-default: false

2
cmd/virtual-kubelet/internal/provider/mock/mock.go
View File

@@ -42,7 +42,7 @@ var (
*/ */
// MockProvider implements the virtual-kubelet provider interface and stores pods in memory. // MockProvider implements the virtual-kubelet provider interface and stores pods in memory.
type MockProvider struct { // nolint:golint type MockProvider struct {
nodeName string nodeName string
operatingSystem string operatingSystem string
internalIP string internalIP string

4
node/node.go
View File

@@ -96,7 +96,7 @@ func NewNodeController(p NodeProvider, node *corev1.Node, nodes v1.NodeInterface
} }
// NodeControllerOpt are the functional options used for configuring a node // NodeControllerOpt are the functional options used for configuring a node
type NodeControllerOpt func(*NodeController) error // nolint: golint type NodeControllerOpt func(*NodeController) error
// WithNodeEnableLeaseV1Beta1 enables support for v1beta1 leases. // WithNodeEnableLeaseV1Beta1 enables support for v1beta1 leases.
// If client is nil, leases will not be enabled. // If client is nil, leases will not be enabled.
@@ -174,7 +174,7 @@ type ErrorHandler func(context.Context, error) error
// NodeController deals with creating and managing a node object in Kubernetes. // NodeController deals with creating and managing a node object in Kubernetes.
// It can register a node with Kubernetes and periodically update its status. // It can register a node with Kubernetes and periodically update its status.
// NodeController manages a single node entity. // NodeController manages a single node entity.
type NodeController struct { // nolint: golint type NodeController struct {
p NodeProvider p NodeProvider
// serverNode should only be written to on initialization, or as the result of node creation. // serverNode should only be written to on initialization, or as the result of node creation.