From 3d1226d45dfe093119a9e42fd5afcccec9b33c7d Mon Sep 17 00:00:00 2001
From: Sargun Dhillon <sargun@sargun.me>
Date: Tue, 8 Sep 2020 12:04:16 -0700
Subject: [PATCH] Fix logging when leases are mis-set

This fixes a small logic bug in the leases code for checking is owner
references are not set correctly, and makes it so that we properly
log when owner references are set, but not set to the node that
is "us".
---
 node/node.go | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/node/node.go b/node/node.go
index f01aaff16..ea643a0ce 100644
--- a/node/node.go
+++ b/node/node.go
@@ -683,19 +683,25 @@ func newLease(ctx context.Context, base *coord.Lease, node *corev1.Node, leaseRe
 			},
 		}
 	} else if l > 0 {
-		var foundThisNode, foundNode bool
+		var foundAnyNode bool
 		for _, ref := range lease.OwnerReferences {
 			if ref.APIVersion == corev1.SchemeGroupVersion.WithKind("Node").Version && ref.Kind == corev1.SchemeGroupVersion.WithKind("Node").Kind {
-				foundNode = true
+				foundAnyNode = true
 				if node.UID == ref.UID && node.Name == ref.Name {
-					foundThisNode = true
+					return lease
+				} else {
+					log.G(ctx).WithFields(map[string]interface{}{
+						"node.UID":  node.UID,
+						"ref.UID":   ref.UID,
+						"node.Name": node.Name,
+						"ref.Name":  ref.Name,
+					}).Warn("Found that lease had node in owner references that is not this node")
 				}
 			}
 		}
-		if !foundThisNode && !foundNode {
+		if !foundAnyNode {
 			log.G(ctx).Warn("Found that lease had owner references, but no nodes in owner references")
-		} else if foundNode {
-			log.G(ctx).Warn("Found that lease had owner references, but nodes in owner references that is not this node")
+
 		}
 	}