log: refactor klogv2 tests

Signed-off-by: Pires <pjpires@gmail.com>
This commit is contained in:
Pires
2021-01-15 18:47:50 +00:00
parent 25b8c546a0
commit cb0e18e6a1

View File

@@ -21,40 +21,47 @@ import (
func TestFieldMap_String(t *testing.T) { func TestFieldMap_String(t *testing.T) {
var tests = []struct { var tests = []struct {
fields fieldMap desc string
fields *fieldMap
expected string expected string
}{ }{
{ {
fieldMap{Fields: nil}, desc: "fieldMap with nil fields",
"", fields: &fieldMap{Fields: nil},
expected: "",
}, },
{ {
fieldMap{Fields: make(log.Fields)}, desc: "fieldMap with empty fields",
"", fields: &fieldMap{Fields: make(log.Fields)},
expected: "",
}, },
{ {
fieldMap{Fields: map[string]interface{}{"one": 1}}, desc: "fieldMap with single field",
" [one=1]", fields: &fieldMap{Fields: map[string]interface{}{"one": 1}},
expected: " [one=1]",
}, },
{ {
fieldMap{Fields: map[string]interface{}{"one": 1, "two": 2}}, desc: "fieldMap with two fields",
" [one=1 two=2]", fields: &fieldMap{Fields: map[string]interface{}{"one": 1, "two": 2}},
expected: " [one=1 two=2]",
}, },
} }
for _, tt := range tests { for _, tt := range tests {
// Assert fields haven't been processed yet. t.Run(tt.desc, func(t *testing.T) {
if len(tt.fields.processedFields) > 0 { // Assert fields haven't been processed yet.
t.Fatal("fields shouldn't have been processed yet") if len(tt.fields.processedFields) > 0 {
} t.Fatal("fields shouldn't have been processed yet")
// Assert fields have been processed, if any. }
actual := tt.fields.String() // Assert fields have been processed, if any.
if len(tt.fields.Fields) > 0 && len(tt.fields.processedFields) == 0 { actual := tt.fields.String()
t.Fatal("fields should have been processed by now") if len(tt.fields.Fields) > 0 && len(tt.fields.processedFields) == 0 {
} t.Fatal("fields should have been processed by now")
// Assert processFields yields desired results. }
if actual != tt.expected { // Assert processFields yields desired results.
t.Fatalf("expected: %s, got: %s", actual, tt.expected) if actual != tt.expected {
} t.Fatalf("expected: %s, got: %s", actual, tt.expected)
}
})
} }
} }