d8dfun/virtual-kubelet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Add Gocritic

Browse Source 
This also fixes the issues laid out by gocritic
This commit is contained in:
Sargun Dhillon
2020-12-05 19:09:18 -08:00
parent ffbfe19e78
commit d29adf5ce3
7 changed files with 34 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
trace/opencensus/opencensus.go
View File

@@ -213,9 +213,9 @@ func (l *logger) WithError(err error) log.Logger {
var a []octrace.Attribute
if l.s.IsRecordingEvents() {
a = make([]octrace.Attribute, len(l.a), len(l.a)+1)
a = make([]octrace.Attribute, len(l.a)+1)
copy(a, l.a)
a = append(l.a, makeAttribute("err", err))
a[len(a)-1] = makeAttribute("err", err)
}
return &logger{s: l.s, l: log, a: a}
@@ -227,9 +227,9 @@ func (l *logger) WithField(k string, value interface{}) log.Logger {
var a []octrace.Attribute
if l.s.IsRecordingEvents() {
a = make([]octrace.Attribute, len(l.a), len(l.a)+1)
a = make([]octrace.Attribute, len(l.a)+1)
copy(a, l.a)
a = append(a, makeAttribute(k, value))
a[len(a)-1] = makeAttribute(k, value)
}
return &logger{s: l.s, a: a, l: log}