From fdb0c805f702ab03787fa98be8ad566b3a054282 Mon Sep 17 00:00:00 2001
From: Ernest Wong <chuwon@microsoft.com>
Date: Thu, 5 Sep 2019 10:48:35 -0700
Subject: [PATCH] Add more unit test to #584

---
 node/pod_test.go | 38 +++++++++++++++++++++++++++++++++++---
 1 file changed, 35 insertions(+), 3 deletions(-)

diff --git a/node/pod_test.go b/node/pod_test.go
index 4f8f4f752..83857a7b1 100644
--- a/node/pod_test.go
+++ b/node/pod_test.go
@@ -213,7 +213,7 @@ func TestPodDelete(t *testing.T) {
 	}
 }
 
-func TestPodUpdateStatus(t *testing.T) {
+func TestFetchPodStatusFromProvider(t *testing.T) {
 	startedAt := metav1.NewTime(time.Now())
 	finishedAt := metav1.NewTime(startedAt.Add(time.Second * 10))
 	containerStateRunning := &corev1.ContainerStateRunning{StartedAt: startedAt}
@@ -255,10 +255,9 @@ func TestPodUpdateStatus(t *testing.T) {
 			assert.NilError(t, err)
 
 			ctx := context.Background()
-			err = c.updatePodStatus(ctx, p.DeepCopy())
+			updatedPod, err := c.fetchPodStatusFromProvider(ctx, nil, p)
 			assert.NilError(t, err)
 
-			updatedPod, err := pc.Get(pod.Name, metav1.GetOptions{})
 			assert.Equal(t, updatedPod.Status.Phase, corev1.PodFailed)
 			assert.Assert(t, is.Len(updatedPod.Status.ContainerStatuses, 1))
 			assert.Assert(t, updatedPod.Status.ContainerStatuses[0].State.Running == nil)
@@ -284,6 +283,39 @@ func TestPodUpdateStatus(t *testing.T) {
 	}
 }
 
+func TestFetchPodStatusFromProviderWithExpiredPod(t *testing.T) {
+	c := newTestController()
+	pod := &corev1.Pod{}
+	pod.ObjectMeta.Namespace = "default"
+	pod.ObjectMeta.Name = "nginx"
+	pod.Status.Phase = corev1.PodRunning
+	containerStatus := corev1.ContainerStatus{}
+
+	// We should terminate containters in a pod that has not provided pod status update for more than a minute
+	startedAt := time.Now().Add(-(time.Minute + time.Second))
+	containerStatus.State.Running = &corev1.ContainerStateRunning{StartedAt: metav1.NewTime(startedAt)}
+	pod.ObjectMeta.CreationTimestamp.Time = startedAt
+	pod.Status.ContainerStatuses = []corev1.ContainerStatus{containerStatus}
+
+	pc := c.client.CoreV1().Pods("default")
+	p, err := pc.Create(pod)
+	assert.NilError(t, err)
+
+	ctx := context.Background()
+	updatedPod, err := c.fetchPodStatusFromProvider(ctx, nil, p)
+	assert.NilError(t, err)
+
+	assert.Equal(t, updatedPod.Status.Phase, corev1.PodFailed)
+	assert.Assert(t, is.Len(updatedPod.Status.ContainerStatuses, 1))
+	assert.Assert(t, updatedPod.Status.ContainerStatuses[0].State.Running == nil)
+	assert.Assert(t, updatedPod.Status.ContainerStatuses[0].State.Terminated != nil)
+	assert.Assert(t, updatedPod.Status.ContainerStatuses[0].State.Waiting == nil)
+
+	terminated := updatedPod.Status.ContainerStatuses[0].State.Terminated
+	assert.Equal(t, terminated.StartedAt, metav1.NewTime(startedAt))
+	assert.Assert(t, terminated.StartedAt.Before(&terminated.FinishedAt))
+}
+
 func newPodSpec() corev1.PodSpec {
 	return corev1.PodSpec{
 		Containers: []corev1.Container{