Commit Graph

5 Commits

Author SHA1 Message Date
Brian Goff
7b92d1eee2 Backport: Fix exec parameter parsing (#580) (#604)
* Fix exec parameter parsing (#580)

Exec seems to be broken by ad6fbba806
This change basically copies what's in remotecommand.NewOptions, just
without the logging.

(cherry picked from commit 449eb3bb7d)

* Don't set cancel function to nil on error

Backported from ceb9b16c5c
2019-05-06 11:32:34 -07:00
Brian Goff
1bfffa975e Make tracing interface to coalesce logging/tracing (#519)
* Define and use an interface for logging.

This allows alternative implementations to use whatever logging package
they want.

Currently the interface just mimicks what logrus already implements,
with minor modifications to not rely on logrus itself. I think the
interface is pretty solid in terms of logging implementations being able
to do what they need to.

* Make tracing interface to coalesce logging/tracing

Allows us to share data between the tracer and the logger so we can
simplify log/trace handling wher we generally want data to go both
places.
2019-02-22 11:36:03 -08:00
Fei Xu
ad6fbba806 parse the exec flags from request query (#510) 2019-02-01 17:05:37 -08:00
Brian Goff
5796be449b Adds some package docs (#479)
Was just browing godoc and noticed we are missing some docs that would
be quite useful.
2019-01-07 11:03:35 -08:00
Brian Goff
da5e24ef4d Move API handlers to separate package
This makes the package split a little cleaner and easier to import the
HTTP handlers for other consumers.
2018-09-18 11:08:24 -07:00