The manual instructions for installation are missing the env.aciRegion variable and will default to "westus", which means it fails if your service principal cannot create container instances there.
Update k8s client and the dependencies
ACI client change for Mocking
Add ACI Provider Mock Tests
Add the Windows development environment
Add UT for Default Resource Requests
Enable the make test in Docker file
Update the vendors
* Updated READ.me
Changed the instructions to use the createCertAndKey.sh file so the execute permissions are applied and added the / to run the shell script. Also commented out the ACI with DNS label instruction until a new version of virtual-kubelet is released that allows this feature.
* Update README.md
had to additional . in createCertAndKey.sh run command to allow for exported environment variables to pass into existing shell
* Read ACS Credentials for Azure Authentication
Supprt a new environment variable: ACS_CREDENTIAL_LOCATION
Expect the value to be the ACS credential filepath, which is the
/etc/kubernetes/azure.json file generated on the ACS nodes.
If the ACS_CREDENTIAL_LOCATION is specified and loaded,
create the Azure Authentication class from its values.
If the AZURE_AUTHENTICATION_LOCATION is specified and loaded,
its values will overwrite the value above.
Refactor the ACI provider and ACI client to be able to override the SPN by environment variable
This seems to be a common typo, possibly exacerbated by copy-paste
of comment strings. I spotted it in the README.md at first, so I fixed
that and then checked the rest of the code and fixed a few more. They
are all in comments or documentation, so there's no code issue.
FYI, there's still some in the vendor directory, but I haven't fixed
those as they'd get replaced by any new `go get` I think:
$ ack uberentes
vendor/k8s.io/apimachinery/hack/godep-deps.sh
20:# 2. godep restore based on k8s.io/kuberentes provided manifest
vendor/k8s.io/client-go/CHANGELOG.md
120:* Included bug fixes in k8s.io/kuberentes release-1.5 branch, up to
vendor/k8s.io/client-go/kubernetes/fake/register.go
64:// clientsetscheme "k8s.io/client-go/kuberentes/scheme"
vendor/k8s.io/client-go/kubernetes/scheme/register.go
64:// clientsetscheme "k8s.io/client-go/kuberentes/scheme"
Sorry, this isn't the most exciting commit in the world :-(
