Vendoring seems to be problematic with go modules. In addition to causing issues with transitive dependencies and being problematic when trying to pull in the node-cli code, it also seems to be pulling different versions than what is computed in go.mod. This can be seen by comparing commits from the computed version in go.mod with very small diffs (like a single Godep change in k8s) but massive vendoring changes. Basically I have very little confidence that this is even working. This should be better in go1.13, but this is not released yet.
178 lines
4.9 KiB
Makefile
178 lines
4.9 KiB
Makefile
SHELL := /bin/bash
|
|
|
|
DOCKER_IMAGE := virtual-kubelet
|
|
exec := $(DOCKER_IMAGE)
|
|
github_repo := virtual-kubelet/virtual-kubelet
|
|
binary := virtual-kubelet
|
|
|
|
export GO111MODULE ?= on
|
|
|
|
include Makefile.e2e
|
|
# Currently this looks for a globally installed gobin. When we move to modules,
|
|
# should consider installing it locally
|
|
# Also, we will want to lock our tool versions using go mod:
|
|
# https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module
|
|
gobin_tool ?= $(shell which gobin || echo $(GOPATH)/bin/gobin)
|
|
goimports := golang.org/x/tools/cmd/goimports@release-branch.go1.12
|
|
gocovmerge := github.com/wadey/gocovmerge@b5bfa59ec0adc420475f97f89b58045c721d761c
|
|
goreleaser := github.com/goreleaser/goreleaser@v0.82.2
|
|
gox := github.com/mitchellh/gox@v1.0.1
|
|
|
|
# comment this line out for quieter things
|
|
# V := 1 # When V is set, print commands and build progress.
|
|
|
|
# Space separated patterns of packages to skip in list, test, format.
|
|
IGNORED_PACKAGES := /vendor/
|
|
|
|
.PHONY: all
|
|
all: test build
|
|
|
|
.PHONY: safebuild
|
|
# safebuild builds inside a docker container with no clingons from your $GOPATH
|
|
safebuild:
|
|
@echo "Building..."
|
|
$Q docker build --build-arg BUILD_TAGS="$(VK_BUILD_TAGS)" -t $(DOCKER_IMAGE):$(VERSION) .
|
|
|
|
.PHONY: build
|
|
build: build_tags := netgo osusergo
|
|
build: OUTPUT_DIR ?= bin
|
|
build: authors
|
|
@echo "Building..."
|
|
$Q CGO_ENABLED=0 go build -ldflags '-extldflags "-static"' -o $(OUTPUT_DIR)/$(binary) $(if $V,-v) $(VERSION_FLAGS) ./cmd/$(binary)
|
|
|
|
.PHONY: tags
|
|
tags:
|
|
@echo "Listing tags..."
|
|
$Q @git tag
|
|
|
|
.PHONY: release
|
|
release: build goreleaser
|
|
$(gobin_tool) -run $(goreleaser)
|
|
|
|
##### =====> Utility targets <===== #####
|
|
|
|
.PHONY: clean test list cover format docker
|
|
mod:
|
|
@echo "Prune Dependencies..."
|
|
$Q go mod tidy
|
|
|
|
docker:
|
|
@echo "Docker Build..."
|
|
$Q docker build --build-arg BUILD_TAGS="$(VK_BUILD_TAGS)" -t $(DOCKER_IMAGE) .
|
|
|
|
clean:
|
|
@echo "Clean..."
|
|
$Q rm -rf bin
|
|
|
|
vet:
|
|
@echo "go vet'ing..."
|
|
ifndef CI
|
|
@echo "go vet'ing Outside CI..."
|
|
$Q go vet $(allpackages)
|
|
else
|
|
@echo "go vet'ing in CI..."
|
|
$Q mkdir -p test
|
|
$Q ( go vet $(allpackages); echo $$? ) | \
|
|
tee test/vet.txt | sed '$$ d'; exit $$(tail -1 test/vet.txt)
|
|
endif
|
|
|
|
test:
|
|
ifndef CI
|
|
@echo "Testing..."
|
|
$Q go test $(if $V,-v) $(allpackages)
|
|
else
|
|
@echo "Testing in CI..."
|
|
$Q mkdir -p test
|
|
$Q ( GODEBUG=cgocheck=2 go test -v $(allpackages); echo $$? ) | \
|
|
tee test/output.txt | sed '$$ d'; exit $$(tail -1 test/output.txt)
|
|
endif
|
|
|
|
list:
|
|
@echo "List..."
|
|
@echo $(allpackages)
|
|
|
|
cover: gocovmerge
|
|
@echo "Coverage Report..."
|
|
@echo "NOTE: make cover does not exit 1 on failure, don't use it to check for tests success!"
|
|
$Q rm -f .GOPATH/cover/*.out cover/all.merged
|
|
$(if $V,@echo "-- go test -coverpkg=./... -coverprofile=cover/... ./...")
|
|
@for MOD in $(allpackages); do \
|
|
go test -coverpkg=`echo $(allpackages)|tr " " ","` \
|
|
-coverprofile=cover/unit-`echo $$MOD|tr "/" "_"`.out \
|
|
$$MOD 2>&1 | grep -v "no packages being tested depend on"; \
|
|
done
|
|
$Q $(gobin_tool) -run $(gocovmerge) cover/*.out > cover/all.merged
|
|
ifndef CI
|
|
@echo "Coverage Report..."
|
|
$Q go tool cover -html .GOPATH/cover/all.merged
|
|
else
|
|
@echo "Coverage Report In CI..."
|
|
$Q go tool cover -html .GOPATH/cover/all.merged -o .GOPATH/cover/all.html
|
|
endif
|
|
@echo ""
|
|
@echo "=====> Total test coverage: <====="
|
|
@echo ""
|
|
$Q go tool cover -func .GOPATH/cover/all.merged
|
|
|
|
format: goimports
|
|
@echo "Formatting..."
|
|
$Q find . -iname \*.go | grep -v \
|
|
-e "^$$" $(addprefix -e ,$(IGNORED_PACKAGES)) | xargs $(gobin_tool) -run $(goimports) -w
|
|
|
|
|
|
|
|
##### =====> Internals <===== #####
|
|
|
|
.PHONY: setup
|
|
setup: goimports gocovmerge goreleaser gox clean
|
|
env
|
|
@echo "Setup..."
|
|
if ! grep "/bin" .gitignore > /dev/null 2>&1; then \
|
|
echo "/bin" >> .gitignore; \
|
|
fi
|
|
if ! grep "/cover" .gitignore > /dev/null 2>&1; then \
|
|
echo "/cover" >> .gitignore; \
|
|
fi
|
|
mkdir -p cover
|
|
mkdir -p bin
|
|
mkdir -p test
|
|
|
|
VERSION := $(shell git describe --tags --always --dirty="-dev")
|
|
DATE := $(shell date -u '+%Y-%m-%d-%H:%M UTC')
|
|
VERSION_FLAGS := -ldflags='-X "main.buildVersion=$(VERSION)" -X "main.buildTime=$(DATE)"'
|
|
|
|
# assuming go 1.9 here!!
|
|
_allpackages = $(shell go list ./...)
|
|
|
|
# memoize allpackages, so that it's executed only once and only if used
|
|
allpackages = $(if $(__allpackages),,$(eval __allpackages := $$(_allpackages)))$(__allpackages)
|
|
|
|
.PHONY: goimports
|
|
goimports: $(gobin_tool)
|
|
$(gobin_tool) -d $(goimports)
|
|
|
|
.PHONY: gocovmerge
|
|
gocovmerge: $(gobin_tool)
|
|
$(gobin_tool) -d $(gocovmerge)
|
|
|
|
.PHONY: goreleaser
|
|
goreleaser: $(gobin_tool)
|
|
$(gobin_tool) -d $(goreleaser)
|
|
|
|
.PHONY: gox
|
|
gox: $(gobin_tool)
|
|
# We make gox globally available, for people to use by hand
|
|
$(gobin_tool) $(gox)
|
|
|
|
Q := $(if $V,,@)
|
|
|
|
$(gobin_tool):
|
|
GO111MODULE=off go get -u github.com/myitcv/gobin
|
|
|
|
authors:
|
|
$Q git log --all --format='%aN <%cE>' | sort -u | sed -n '/github/!p' > GITAUTHORS
|
|
$Q cat AUTHORS GITAUTHORS | sort -u > NEWAUTHORS
|
|
$Q mv NEWAUTHORS AUTHORS
|
|
$Q rm -f NEWAUTHORS
|
|
$Q rm -f GITAUTHORS
|