513cebe7b7
* Add Virtual Kubelet provider for VIC Initial virtual kubelet provider for VMware VIC. This provider currently handles creating and starting of a pod VM via the VIC portlayer and persona server. Image store handling via the VIC persona server. This provider currently requires the feature/wolfpack branch of VIC. * Added pod stop and delete. Also added node capacity. Added the ability to stop and delete pod VMs via VIC. Also retrieve node capacity information from the VCH. * Cleanup and readme file Some file clean up and added a Readme.md markdown file for the VIC provider. * Cleaned up errors, added function comments, moved operation code 1. Cleaned up error handling. Set standard for creating errors. 2. Added method prototype comments for all interface functions. 3. Moved PodCreator, PodStarter, PodStopper, and PodDeleter to a new folder. * Add mocking code and unit tests for podcache, podcreator, and podstarter Used the unit test framework used in VIC to handle assertions in the provider's unit test. Mocking code generated using OSS project mockery, which is compatible with the testify assertion framework. * Vendored packages for the VIC provider Requires feature/wolfpack branch of VIC and a few specific commit sha of projects used within VIC. * Implementation of POD Stopper and Deleter unit tests (#4) * Updated files for initial PR
608 lines
19 KiB
Go
608 lines
19 KiB
Go
// Copyright 2015 go-swagger maintainers
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package validate
|
|
|
|
import (
|
|
"encoding/json"
|
|
"io/ioutil"
|
|
"log"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/go-openapi/analysis"
|
|
"github.com/go-openapi/loads"
|
|
"github.com/go-openapi/loads/fmts"
|
|
"github.com/go-openapi/spec"
|
|
"github.com/go-openapi/strfmt"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func init() {
|
|
loads.AddLoader(fmts.YAMLMatcher, fmts.YAMLDoc)
|
|
}
|
|
|
|
func TestExpandResponseLocalFile(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "local_expansion", "spec.yaml")
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
if assert.NotNil(t, doc) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
assert.True(t, res.IsValid())
|
|
assert.Empty(t, res.Errors)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestExpandResponseRecursive(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "recursive_expansion", "spec.yaml")
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
if assert.NotNil(t, doc) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
assert.True(t, res.IsValid())
|
|
assert.Empty(t, res.Errors)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIssue52(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "bugs", "52", "swagger.json")
|
|
jstext, _ := ioutil.ReadFile(fp)
|
|
|
|
// as json schema
|
|
var sch spec.Schema
|
|
if assert.NoError(t, json.Unmarshal(jstext, &sch)) {
|
|
validator := NewSchemaValidator(spec.MustLoadSwagger20Schema(), nil, "", strfmt.Default)
|
|
res := validator.Validate(&sch)
|
|
assert.False(t, res.IsValid())
|
|
assert.EqualError(t, res.Errors[0], ".paths in body is required")
|
|
}
|
|
|
|
// as swagger spec
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
assert.False(t, res.IsValid())
|
|
assert.EqualError(t, res.Errors[0], ".paths in body is required")
|
|
}
|
|
|
|
}
|
|
|
|
func TestIssue53(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "bugs", "53", "noswagger.json")
|
|
jstext, _ := ioutil.ReadFile(fp)
|
|
|
|
// as json schema
|
|
var sch spec.Schema
|
|
if assert.NoError(t, json.Unmarshal(jstext, &sch)) {
|
|
validator := NewSchemaValidator(spec.MustLoadSwagger20Schema(), nil, "", strfmt.Default)
|
|
res := validator.Validate(&sch)
|
|
assert.False(t, res.IsValid())
|
|
assert.EqualError(t, res.Errors[0], ".swagger in body is required")
|
|
}
|
|
|
|
// as swagger spec
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
if assert.False(t, res.IsValid()) {
|
|
assert.EqualError(t, res.Errors[0], ".swagger in body is required")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIssue62(t *testing.T) {
|
|
t.SkipNow()
|
|
fp := filepath.Join("fixtures", "bugs", "62", "swagger.json")
|
|
|
|
// as swagger spec
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.True(t, res.HasErrors())
|
|
}
|
|
}
|
|
|
|
func TestIssue63(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "bugs", "63", "swagger.json")
|
|
|
|
// as swagger spec
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
assert.True(t, res.IsValid())
|
|
}
|
|
}
|
|
|
|
func TestIssue61_MultipleRefs(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "bugs", "61", "multiple-refs.json")
|
|
|
|
// as swagger spec
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
assert.Empty(t, res.Errors)
|
|
assert.True(t, res.IsValid())
|
|
}
|
|
}
|
|
|
|
func TestIssue61_ResolvedRef(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "bugs", "61", "unresolved-ref-for-name.json")
|
|
|
|
// as swagger spec
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
assert.Empty(t, res.Errors)
|
|
assert.True(t, res.IsValid())
|
|
}
|
|
}
|
|
|
|
func TestIssue123(t *testing.T) {
|
|
fp := filepath.Join("fixtures", "bugs", "123", "swagger.yml")
|
|
|
|
// as swagger spec
|
|
doc, err := loads.Spec(fp)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
for _, e := range res.Errors {
|
|
log.Println(e)
|
|
}
|
|
assert.True(t, res.IsValid())
|
|
}
|
|
}
|
|
|
|
func TestIssue6(t *testing.T) {
|
|
files, _ := filepath.Glob(filepath.Join("fixtures", "bugs", "6", "*.json"))
|
|
for _, path := range files {
|
|
doc, err := loads.Spec(path)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
for _, e := range res.Errors {
|
|
log.Println(e)
|
|
}
|
|
assert.False(t, res.IsValid())
|
|
}
|
|
}
|
|
}
|
|
|
|
// check if invalid patterns are indeed invalidated
|
|
func TestIssue18(t *testing.T) {
|
|
files, _ := filepath.Glob(filepath.Join("fixtures", "bugs", "18", "*.json"))
|
|
for _, path := range files {
|
|
doc, err := loads.Spec(path)
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(doc.Schema(), strfmt.Default)
|
|
res, _ := validator.Validate(doc)
|
|
for _, e := range res.Errors {
|
|
log.Println(e)
|
|
}
|
|
assert.False(t, res.IsValid())
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDuplicatePropertyNames(t *testing.T) {
|
|
// simple allOf
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "duplicateprops.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
res := validator.validateDuplicatePropertyNames()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
|
|
}
|
|
|
|
// nested allOf
|
|
doc, err = loads.Spec(filepath.Join("fixtures", "validation", "nestedduplicateprops.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
res := validator.validateDuplicatePropertyNames()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
|
|
}
|
|
}
|
|
|
|
func TestValidateNonEmptyPathParameterNames(t *testing.T) {
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "empty-path-param-name.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
res := validator.validateNonEmptyPathParamNames()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
|
|
}
|
|
}
|
|
|
|
func TestValidateCircularAncestry(t *testing.T) {
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "direct-circular-ancestor.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
res := validator.validateDuplicatePropertyNames()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
}
|
|
|
|
doc, err = loads.Spec(filepath.Join("fixtures", "validation", "indirect-circular-ancestor.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
res := validator.validateDuplicatePropertyNames()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
}
|
|
|
|
doc, err = loads.Spec(filepath.Join("fixtures", "validation", "recursive-circular-ancestor.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
res := validator.validateDuplicatePropertyNames()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
}
|
|
|
|
}
|
|
|
|
func TestValidateUniqueSecurityScopes(t *testing.T) {
|
|
}
|
|
|
|
func TestValidateReferenced(t *testing.T) {
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "valid-referenced.yml"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateReferenced()
|
|
assert.Empty(t, res.Errors)
|
|
}
|
|
|
|
doc, err = loads.Spec(filepath.Join("fixtures", "validation", "invalid-referenced.yml"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateReferenced()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 3)
|
|
}
|
|
}
|
|
|
|
func TestValidateBodyFormDataParams(t *testing.T) {
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "invalid-formdata-body-params.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateDefaultValueValidAgainstSchema()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
}
|
|
}
|
|
|
|
func TestValidateReferencesValid(t *testing.T) {
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "valid-ref.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateReferencesValid()
|
|
assert.Empty(t, res.Errors)
|
|
}
|
|
|
|
doc, err = loads.Spec(filepath.Join("fixtures", "validation", "invalid-ref.json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateReferencesValid()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
}
|
|
}
|
|
|
|
func TestValidatesExamplesAgainstSchema(t *testing.T) {
|
|
tests := []string{
|
|
"response",
|
|
"response-ref",
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "valid-example-"+tt+".json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateExamplesValidAgainstSchema()
|
|
assert.Empty(t, res.Errors, tt+" should not have errors")
|
|
}
|
|
|
|
doc, err = loads.Spec(filepath.Join("fixtures", "validation", "invalid-example-"+tt+".json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateExamplesValidAgainstSchema()
|
|
assert.NotEmpty(t, res.Errors, tt+" should have errors")
|
|
assert.Len(t, res.Errors, 1, tt+" should have 1 error")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDefaultValueAgainstSchema(t *testing.T) {
|
|
doc, _ := loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateDefaultValueValidAgainstSchema()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
tests := []string{
|
|
"parameter",
|
|
"parameter-ref",
|
|
"parameter-items",
|
|
"header",
|
|
"header-items",
|
|
"schema",
|
|
"schema-ref",
|
|
"schema-additionalProperties",
|
|
"schema-patternProperties",
|
|
"schema-items",
|
|
"schema-allOf",
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
doc, err := loads.Spec(filepath.Join("fixtures", "validation", "valid-default-value-"+tt+".json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateDefaultValueValidAgainstSchema()
|
|
assert.Empty(t, res.Errors, tt+" should not have errors")
|
|
}
|
|
|
|
doc, err = loads.Spec(filepath.Join("fixtures", "validation", "invalid-default-value-"+tt+".json"))
|
|
if assert.NoError(t, err) {
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateDefaultValueValidAgainstSchema()
|
|
assert.NotEmpty(t, res.Errors, tt+" should have errors")
|
|
assert.Len(t, res.Errors, 1, tt+" should have 1 error")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateRequiredDefinitions(t *testing.T) {
|
|
doc, _ := loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateRequiredDefinitions()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
// properties
|
|
sw := doc.Spec()
|
|
def := sw.Definitions["Tag"]
|
|
def.Required = append(def.Required, "type")
|
|
sw.Definitions["Tag"] = def
|
|
res = validator.validateRequiredDefinitions()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
// pattern properties
|
|
def.PatternProperties = make(map[string]spec.Schema)
|
|
def.PatternProperties["ty.*"] = *spec.StringProperty()
|
|
sw.Definitions["Tag"] = def
|
|
res = validator.validateRequiredDefinitions()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
def.PatternProperties = make(map[string]spec.Schema)
|
|
def.PatternProperties["^ty.$"] = *spec.StringProperty()
|
|
sw.Definitions["Tag"] = def
|
|
res = validator.validateRequiredDefinitions()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
// additional properties
|
|
def.PatternProperties = nil
|
|
def.AdditionalProperties = &spec.SchemaOrBool{Allows: true}
|
|
sw.Definitions["Tag"] = def
|
|
res = validator.validateRequiredDefinitions()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
def.AdditionalProperties = &spec.SchemaOrBool{Allows: false}
|
|
sw.Definitions["Tag"] = def
|
|
res = validator.validateRequiredDefinitions()
|
|
assert.NotEmpty(t, res.Errors)
|
|
}
|
|
|
|
func TestValidateParameters(t *testing.T) {
|
|
doc, _ := loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateParameters()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
sw := doc.Spec()
|
|
sw.Paths.Paths["/pets"].Get.Parameters = append(sw.Paths.Paths["/pets"].Get.Parameters, *spec.QueryParam("limit").Typed("string", ""))
|
|
res = validator.validateParameters()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
doc, _ = loads.Analyzed(PetStoreJSONMessage, "")
|
|
sw = doc.Spec()
|
|
sw.Paths.Paths["/pets"].Post.Parameters = append(sw.Paths.Paths["/pets"].Post.Parameters, *spec.BodyParam("fake", spec.RefProperty("#/definitions/Pet")))
|
|
validator = NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res = validator.validateParameters()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
assert.Contains(t, res.Errors[0].Error(), "has more than 1 body param")
|
|
|
|
doc, _ = loads.Analyzed(PetStoreJSONMessage, "")
|
|
sw = doc.Spec()
|
|
pp := sw.Paths.Paths["/pets/{id}"]
|
|
pp.Delete = nil
|
|
var nameParams []spec.Parameter
|
|
for _, p := range pp.Parameters {
|
|
if p.Name == "id" {
|
|
p.Name = "name"
|
|
nameParams = append(nameParams, p)
|
|
}
|
|
}
|
|
pp.Parameters = nameParams
|
|
sw.Paths.Paths["/pets/{name}"] = pp
|
|
|
|
validator = NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res = validator.validateParameters()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 1)
|
|
assert.Contains(t, res.Errors[0].Error(), "overlaps with")
|
|
|
|
doc, _ = loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator = NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
sw = doc.Spec()
|
|
pp = sw.Paths.Paths["/pets/{id}"]
|
|
pp.Delete = nil
|
|
pp.Get.Parameters = nameParams
|
|
pp.Parameters = nil
|
|
sw.Paths.Paths["/pets/{id}"] = pp
|
|
|
|
res = validator.validateParameters()
|
|
assert.NotEmpty(t, res.Errors)
|
|
assert.Len(t, res.Errors, 2)
|
|
assert.Contains(t, res.Errors[1].Error(), "is not present in path \"/pets/{id}\"")
|
|
assert.Contains(t, res.Errors[0].Error(), "has no parameter definition")
|
|
}
|
|
|
|
func TestValidateItems(t *testing.T) {
|
|
doc, _ := loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator := NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
res := validator.validateItems()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
// in operation parameters
|
|
sw := doc.Spec()
|
|
sw.Paths.Paths["/pets"].Get.Parameters[0].Type = "array"
|
|
res = validator.validateItems()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
sw.Paths.Paths["/pets"].Get.Parameters[0].Items = spec.NewItems().Typed("string", "")
|
|
res = validator.validateItems()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
sw.Paths.Paths["/pets"].Get.Parameters[0].Items = spec.NewItems().Typed("array", "")
|
|
res = validator.validateItems()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
sw.Paths.Paths["/pets"].Get.Parameters[0].Items.Items = spec.NewItems().Typed("string", "")
|
|
res = validator.validateItems()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
// in global parameters
|
|
sw.Parameters = make(map[string]spec.Parameter)
|
|
sw.Parameters["other"] = *spec.SimpleArrayParam("other", "array", "csv")
|
|
res = validator.validateItems()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
//pp := spec.SimpleArrayParam("other", "array", "")
|
|
//pp.Items = nil
|
|
//sw.Parameters["other"] = *pp
|
|
//res = validator.validateItems()
|
|
//assert.NotEmpty(t, res.Errors)
|
|
|
|
// in shared path object parameters
|
|
doc, _ = loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator = NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
sw = doc.Spec()
|
|
|
|
pa := sw.Paths.Paths["/pets"]
|
|
pa.Parameters = []spec.Parameter{*spec.SimpleArrayParam("another", "array", "csv")}
|
|
sw.Paths.Paths["/pets"] = pa
|
|
res = validator.validateItems()
|
|
assert.Empty(t, res.Errors)
|
|
|
|
pa = sw.Paths.Paths["/pets"]
|
|
pp := spec.SimpleArrayParam("other", "array", "")
|
|
pp.Items = nil
|
|
pa.Parameters = []spec.Parameter{*pp}
|
|
sw.Paths.Paths["/pets"] = pa
|
|
res = validator.validateItems()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
// in body param schema
|
|
doc, _ = loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator = NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
sw = doc.Spec()
|
|
pa = sw.Paths.Paths["/pets"]
|
|
pa.Post.Parameters[0].Schema = spec.ArrayProperty(nil)
|
|
res = validator.validateItems()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
// in response headers
|
|
doc, _ = loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator = NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
sw = doc.Spec()
|
|
pa = sw.Paths.Paths["/pets"]
|
|
rp := pa.Post.Responses.StatusCodeResponses[200]
|
|
var hdr spec.Header
|
|
hdr.Type = "array"
|
|
rp.Headers = make(map[string]spec.Header)
|
|
rp.Headers["X-YADA"] = hdr
|
|
pa.Post.Responses.StatusCodeResponses[200] = rp
|
|
res = validator.validateItems()
|
|
assert.NotEmpty(t, res.Errors)
|
|
|
|
// in response schema
|
|
doc, _ = loads.Analyzed(PetStoreJSONMessage, "")
|
|
validator = NewSpecValidator(spec.MustLoadSwagger20Schema(), strfmt.Default)
|
|
validator.spec = doc
|
|
validator.analyzer = analysis.New(doc.Spec())
|
|
sw = doc.Spec()
|
|
pa = sw.Paths.Paths["/pets"]
|
|
rp = pa.Post.Responses.StatusCodeResponses[200]
|
|
rp.Schema = spec.ArrayProperty(nil)
|
|
pa.Post.Responses.StatusCodeResponses[200] = rp
|
|
res = validator.validateItems()
|
|
assert.NotEmpty(t, res.Errors)
|
|
}
|