Files
virtual-kubelet/providers/vic/operations/pod_deleter.go
Loc Nguyen 513cebe7b7 VMware vSphere Integrated Containers provider (#206)
* Add Virtual Kubelet provider for VIC

Initial virtual kubelet provider for VMware VIC.  This provider currently
handles creating and starting of a pod VM via the VIC portlayer and persona
server.  Image store handling via the VIC persona server.  This provider
currently requires the feature/wolfpack branch of VIC.

* Added pod stop and delete.  Also added node capacity.

Added the ability to stop and delete pod VMs via VIC.  Also retrieve
node capacity information from the VCH.

* Cleanup and readme file

Some file clean up and added a Readme.md markdown file for the VIC
provider.

* Cleaned up errors, added function comments, moved operation code

1. Cleaned up error handling.  Set standard for creating errors.
2. Added method prototype comments for all interface functions.
3. Moved PodCreator, PodStarter, PodStopper, and PodDeleter to a new folder.

* Add mocking code and unit tests for podcache, podcreator, and podstarter

Used the unit test framework used in VIC to handle assertions in the provider's
unit test.  Mocking code generated using OSS project mockery, which is compatible
with the testify assertion framework.

* Vendored packages for the VIC provider

Requires feature/wolfpack branch of VIC and a few specific commit sha of
projects used within VIC.

* Implementation of POD Stopper and Deleter unit tests (#4)

* Updated files for initial PR
2018-06-04 15:41:32 -07:00

175 lines
4.7 KiB
Go

package operations
import (
"fmt"
"github.com/virtual-kubelet/virtual-kubelet/providers/vic/cache"
vicpod "github.com/virtual-kubelet/virtual-kubelet/providers/vic/pod"
"github.com/virtual-kubelet/virtual-kubelet/providers/vic/proxy"
vicerrors "github.com/vmware/vic/lib/apiservers/engine/errors"
"github.com/vmware/vic/lib/apiservers/portlayer/client"
"github.com/vmware/vic/pkg/retry"
"github.com/vmware/vic/pkg/trace"
"k8s.io/api/core/v1"
)
type PodDeleter interface {
DeletePod(op trace.Operation, pod *v1.Pod) error
}
type VicPodDeleter struct {
client *client.PortLayer
imageStore proxy.ImageStore
isolationProxy proxy.IsolationProxy
podCache cache.PodCache
personaAddr string
portlayerAddr string
}
type VicPodDeleterError string
func (e VicPodDeleterError) Error() string { return string(e) }
const (
PodDeleterPortlayerClientError = VicPodDeleterError("PodDeleter called with an invalid portlayer client")
PodDeleterIsolationProxyError = VicPodDeleterError("PodDeleter called with an invalid isolation proxy")
PodDeleterPodCacheError = VicPodDeleterError("PodDeleter called with an invalid pod cache")
PodDeleterPersonaAddrError = VicPodDeleterError("PodDeleter called with an invalid VIC persona addr")
PodDeleterPortlayerAddrError = VicPodDeleterError("PodDeleter called with an invalid VIC portlayer addr")
PodDeleterInvalidPodSpecError = VicPodDeleterError("PodDeleter called with nil pod")
)
type DeleteResponse struct {
Id string `json:"Id"`
Warnings string `json:"Warnings"`
}
func NewPodDeleter(client *client.PortLayer, isolationProxy proxy.IsolationProxy, podCache cache.PodCache, personaAddr string, portlayerAddr string) (PodDeleter, error) {
if client == nil {
return nil, PodDeleterPortlayerClientError
} else if isolationProxy == nil {
return nil, PodDeleterIsolationProxyError
} else if podCache == nil {
return nil, PodDeleterPodCacheError
}
return &VicPodDeleter{
client: client,
podCache: podCache,
personaAddr: personaAddr,
portlayerAddr: portlayerAddr,
isolationProxy: isolationProxy,
}, nil
}
// DeletePod deletes a pod
//
// arguments:
// op operation trace logger
// pod pod spec
// returns:
// error
func (v *VicPodDeleter) DeletePod(op trace.Operation, pod *v1.Pod) error {
if pod == nil {
return PodDeleterInvalidPodSpecError
}
defer trace.End(trace.Begin(pod.Name, op))
// Get pod from cache
vp, err := v.podCache.Get(op, "", pod.Name)
if err != nil {
return err
}
// Stop pod if not already stopped
// Transform kube container config to docker create config
err = v.deletePod(op, vp, true)
if err != nil {
op.Errorf("PodDeleter failed to delete pod: %s", err.Error())
return err
}
op.Infof("PodDeleter deleting from cache, name: %s, ID: %s", pod.Name, vp.ID)
v.podCache.Delete(op, "", pod.Name)
return nil
}
// deletePod deletes a pod
//
// arguments:
// op operation trace logger
// vp VIC pod struct
// force if set to true, the pod will be deleted even if it's still running
// returns:
// error
func (v *VicPodDeleter) deletePod(op trace.Operation, vp *vicpod.VicPod, force bool) error {
defer trace.End(trace.Begin("", op))
if vp == nil {
return PodDeleterInvalidPodSpecError
}
id := vp.ID
name := vp.Pod.Name
running := false
stopper, err := NewPodStopper(v.client, v.isolationProxy)
if err != nil {
return err
}
// Use the force and stop the container first
if force {
if err := stopper.Stop(op, id, name); err != nil {
return err
}
} else {
state, err := v.isolationProxy.State(op, id, name)
if err != nil {
return err
}
switch state {
case "Error":
// force stop if container state is error to make sure container is deletable later
stopper.Stop(op, id, name)
case "Starting":
// if we are starting let the user know they must use the force
return fmt.Errorf("The container is starting. To remove use -f")
case "Running":
running = true
}
handle, err := v.isolationProxy.Handle(op, id, name)
if err != nil {
return err
}
// Unbind the container to the scope
_, ep, err := v.isolationProxy.UnbindScope(op, handle, name)
if err != nil {
return err
}
op.Infof("Scope Unbind returned endpoints %# +v", ep)
}
// Retry remove operation if container is not in running state. If in running state, we only try
// once to prevent retries from degrading performance.
if !running {
operation := func() error {
return v.isolationProxy.Remove(op, id, true)
}
op.Infof("Delete Pod, ID: %s, running: %v", vp.ID, running)
return retry.Do(operation, vicerrors.IsConflictError)
}
err = v.isolationProxy.Remove(op, id, true)
op.Infof("Delete Pod, ID: %s, running: %v err: %v", vp.ID, running, err)
return err
}