513cebe7b7
* Add Virtual Kubelet provider for VIC Initial virtual kubelet provider for VMware VIC. This provider currently handles creating and starting of a pod VM via the VIC portlayer and persona server. Image store handling via the VIC persona server. This provider currently requires the feature/wolfpack branch of VIC. * Added pod stop and delete. Also added node capacity. Added the ability to stop and delete pod VMs via VIC. Also retrieve node capacity information from the VCH. * Cleanup and readme file Some file clean up and added a Readme.md markdown file for the VIC provider. * Cleaned up errors, added function comments, moved operation code 1. Cleaned up error handling. Set standard for creating errors. 2. Added method prototype comments for all interface functions. 3. Moved PodCreator, PodStarter, PodStopper, and PodDeleter to a new folder. * Add mocking code and unit tests for podcache, podcreator, and podstarter Used the unit test framework used in VIC to handle assertions in the provider's unit test. Mocking code generated using OSS project mockery, which is compatible with the testify assertion framework. * Vendored packages for the VIC provider Requires feature/wolfpack branch of VIC and a few specific commit sha of projects used within VIC. * Implementation of POD Stopper and Deleter unit tests (#4) * Updated files for initial PR
213 lines
6.7 KiB
Go
213 lines
6.7 KiB
Go
package operations
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/vmware/vic/lib/apiservers/portlayer/client"
|
|
)
|
|
|
|
func init() {
|
|
initPod()
|
|
}
|
|
|
|
func TestNewPodDeleter(t *testing.T) {
|
|
_, ip, cache, _ := createMocks(t)
|
|
client := client.Default
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
// Positive Cases
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
|
|
// Negative Cases
|
|
d, err = NewPodDeleter(nil, ip, cache, persona, portlayer)
|
|
assert.Nil(t, d, "Expected nil")
|
|
assert.Equal(t, err, PodDeleterPortlayerClientError)
|
|
|
|
d, err = NewPodDeleter(client, nil, cache, persona, portlayer)
|
|
assert.Nil(t, d, "Expected nil")
|
|
assert.Equal(t, err, PodDeleterIsolationProxyError)
|
|
|
|
d, err = NewPodDeleter(client, ip, nil, persona, portlayer)
|
|
assert.Nil(t, d, "Expected nil")
|
|
assert.Equal(t, err, PodDeleterPodCacheError)
|
|
}
|
|
|
|
func TestDeletePod(t *testing.T) {
|
|
client := client.Default
|
|
_, ip, cache, op := createMocks(t)
|
|
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
assert.Nil(t, err, "Expected nil")
|
|
|
|
// Set up the mocks for this test
|
|
ip.On("Handle", op, podID, podName).Return(podHandle, nil)
|
|
ip.On("UnbindScope", op, podHandle, podName).Return(podHandle, fakeEP, nil)
|
|
ip.On("SetState", op, podHandle, podName, "STOPPED").Return(podHandle, nil)
|
|
ip.On("CommitHandle", op, podHandle, podID, int32(-1)).Return(nil)
|
|
ip.On("Remove", op, podID, true).Return(nil)
|
|
|
|
// Add vicPod to the cache
|
|
cache.Add(op, "", pod.Name, &vicPod)
|
|
|
|
// Positive case
|
|
err = d.DeletePod(op, &pod)
|
|
assert.Nil(t, err, "Expected nil")
|
|
}
|
|
|
|
func TestDeletePodErrorHandle(t *testing.T) {
|
|
client := client.Default
|
|
_, ip, cache, op := createMocks(t)
|
|
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
assert.Nil(t, err, "Expected nil")
|
|
|
|
// Set up the mocks for this test
|
|
ip.On("UnbindScope", op, podHandle, podName).Return(podHandle, fakeEP, nil)
|
|
ip.On("SetState", op, podHandle, podName, "STOPPED").Return(podHandle, nil)
|
|
ip.On("CommitHandle", op, podHandle, podID, int32(-1)).Return(nil)
|
|
ip.On("Remove", op, podID, true).Return(nil)
|
|
|
|
// Add vicPod to the cache
|
|
cache.Add(op, "", pod.Name, &vicPod)
|
|
|
|
// Failed Handle
|
|
fakeErr := fakeError("invalid handle")
|
|
ip.On("Handle", op, podID, podName).Return("", fakeErr)
|
|
|
|
err = d.DeletePod(op, &pod)
|
|
assert.Equal(t, err, fakeErr, "Expected invalid handle error")
|
|
}
|
|
|
|
func TestDeletePodErrorUnbindScope(t *testing.T) {
|
|
client := client.Default
|
|
_, ip, cache, op := createMocks(t)
|
|
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
assert.Nil(t, err, "Expected nil")
|
|
|
|
// Set up the mocks for this test
|
|
ip.On("Handle", op, podID, podName).Return(podHandle, nil)
|
|
ip.On("SetState", op, podHandle, podName, "STOPPED").Return(podHandle, nil)
|
|
ip.On("CommitHandle", op, podHandle, podID, int32(-1)).Return(nil)
|
|
ip.On("Remove", op, podID, true).Return(nil)
|
|
|
|
// Add vicPod to the cache
|
|
cache.Add(op, "", pod.Name, &vicPod)
|
|
// Failed UnbindScope
|
|
fakeErr := fakeError("failed UnbindScope")
|
|
ip.On("UnbindScope", op, podHandle, podName).Return("", nil, fakeErr)
|
|
|
|
err = d.DeletePod(op, &pod)
|
|
assert.Equal(t, err, fakeErr, "Expected failed UnbindScope error")
|
|
}
|
|
|
|
func TestDeletePodErrorSetState(t *testing.T) {
|
|
client := client.Default
|
|
_, ip, cache, op := createMocks(t)
|
|
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
assert.Nil(t, err, "Expected nil")
|
|
|
|
// Set up the mocks for this test
|
|
ip.On("Handle", op, podID, podName).Return(podHandle, nil)
|
|
ip.On("UnbindScope", op, podHandle, podName).Return(podHandle, fakeEP, nil)
|
|
ip.On("CommitHandle", op, podHandle, podID, int32(-1)).Return(nil)
|
|
ip.On("Remove", op, podID, true).Return(nil)
|
|
|
|
// Add vicPod to the cache
|
|
cache.Add(op, "", pod.Name, &vicPod)
|
|
|
|
// Failed SetState
|
|
fakeErr := fakeError("failed SetState")
|
|
ip.On("SetState", op, podHandle, podName, "STOPPED").Return("", fakeErr)
|
|
err = d.DeletePod(op, &pod)
|
|
assert.Equal(t, err, fakeErr, "Expected failed SetState error")
|
|
}
|
|
|
|
func TestDeletePodErrorCommitHandle(t *testing.T) {
|
|
client := client.Default
|
|
_, ip, cache, op := createMocks(t)
|
|
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
assert.Nil(t, err, "Expected nil")
|
|
|
|
// Set up the mocks for this test
|
|
ip.On("Handle", op, podID, podName).Return(podHandle, nil)
|
|
ip.On("UnbindScope", op, podHandle, podName).Return(podHandle, fakeEP, nil)
|
|
ip.On("SetState", op, podHandle, podName, "STOPPED").Return(podHandle, nil)
|
|
ip.On("Remove", op, podID, true).Return(nil)
|
|
|
|
// Add vicPod to the cache
|
|
cache.Add(op, "", pod.Name, &vicPod)
|
|
// Failed Commit
|
|
fakeErr := fakeError("failed Commit")
|
|
ip.On("CommitHandle", op, podHandle, podID, int32(-1)).Return(fakeErr)
|
|
err = d.DeletePod(op, &pod)
|
|
assert.Equal(t, err, fakeErr, "Expected failed Commit error")
|
|
}
|
|
|
|
func TestDeletePodErrorRemove(t *testing.T) {
|
|
client := client.Default
|
|
_, ip, cache, op := createMocks(t)
|
|
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
assert.Nil(t, err, "Expected nil")
|
|
|
|
// Set up the mocks for this test
|
|
ip.On("Handle", op, podID, podName).Return(podHandle, nil)
|
|
ip.On("UnbindScope", op, podHandle, podName).Return(podHandle, fakeEP, nil)
|
|
ip.On("SetState", op, podHandle, podName, "STOPPED").Return(podHandle, nil)
|
|
ip.On("CommitHandle", op, podHandle, podID, int32(-1)).Return(nil)
|
|
|
|
// Add vicPod to the cache
|
|
cache.Add(op, "", pod.Name, &vicPod)
|
|
|
|
// Failed Remove
|
|
fakeErr := fakeError("failed Remove")
|
|
ip.On("Remove", op, podID, true).Return(fakeErr)
|
|
err = d.DeletePod(op, &pod)
|
|
assert.Equal(t, err, fakeErr, "Expected failed Remove error")
|
|
}
|
|
|
|
func TestDeletePodErrorBadArgs(t *testing.T) {
|
|
client := client.Default
|
|
_, ip, cache, op := createMocks(t)
|
|
persona := "1.2.3.4"
|
|
portlayer := "1.2.3.4"
|
|
|
|
d, err := NewPodDeleter(client, ip, cache, persona, portlayer)
|
|
assert.NotNil(t, d, "Expected non-nil creating a pod Deleter but received nil")
|
|
|
|
// Negative Cases
|
|
err = d.DeletePod(op, nil)
|
|
assert.Equal(t, err, PodDeleterInvalidPodSpecError)
|
|
}
|