d8dfun/bmad-method-template
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sync: visual-diff-pencil - improve detection accuracy (add name normalization, cross-validation, structure check) #30

Merged
d8dfun merged 1 commits from sync/d8d-skills-20260413-163204 into master 2026-04-14 08:48:25 +08:00
Conversation 0 Commits 1 Files Changed 1 +90 -23
d8dfun commented 2026-04-14 00:32:47 +08:00
Owner
Copy Link

变更内容

Improve detection accuracy for prototype comparison:

  1. Add name normalization: supports numbered design frame names like '12. Withdraw' → correctly extract 'withdraw' for route matching
  2. Add pages.json cross-validation: ensures all pages in code get compared, no more missing pages
  3. Add structure check: extract required components from .pen node tree before visual comparison → detects missing blocks early
  4. Add enforced checklist: icon mismatch must be counted as moderate difference (don't skip counting because 'it doesn't affect functionality')
  5. Add examples: clear guidance for correct grading

Testing

  • ✓ Fixed production issue: withdraw page had 3 blocks missing but wasn't detected due to name matching failure
  • ✓ Now works correctly
## 变更内容 Improve detection accuracy for prototype comparison: 1. **Add name normalization**: supports numbered design frame names like '12. Withdraw' → correctly extract 'withdraw' for route matching 2. **Add pages.json cross-validation**: ensures all pages in code get compared, no more missing pages 3. **Add structure check**: extract required components from .pen node tree before visual comparison → detects missing blocks early 4. **Add enforced checklist**: icon mismatch must be counted as moderate difference (don't skip counting because 'it doesn't affect functionality') 5. **Add examples**: clear guidance for correct grading ## Testing - ✓ Fixed production issue: withdraw page had 3 blocks missing but wasn't detected due to name matching failure - ✓ Now works correctly
d8dfun added 1 commit 2026-04-14 00:32:48 +08:00
sync: visual-diff-pencil - add name normalization, pages.json cross-validation, structure check using .pen node tree f932768e35 
This improves detection accuracy:
1. Add name normalization for numbered design frame names (e.g., '12. Withdraw' → 'withdraw')
2. Add pages.json cross-validation to ensure no pages are missed
3. Add structure check using .pen node tree before visual comparison - detects missing blocks early
4. Add enforced checklist for correct difference counting - icon mismatch must be counted as moderate
5. Add examples for correct grading
d8dfun merged commit 6146561510 into master 2026-04-14 08:48:25 +08:00
d8dfun deleted branch sync/d8d-skills-20260413-163204 2026-04-14 08:48:26 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
d8dfun
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: d8dfun/bmad-method-template#30
No description provided.
Delete Branch "sync/d8d-skills-20260413-163204"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?