skaffold target requires .SECONDEXPANSION (#696)
Otherwise the variable is evaluated before it's even set (assuming it's not set from the CLI). skaffold also requires bin/e2e/virtual-kubelet to work on it's own.
This commit is contained in:
@@ -11,7 +11,8 @@ skaffold.validate:
|
||||
# MODE must be set to one of "dev" (default), "delete" or "run", and is used as the skaffold command to be run.
|
||||
.PHONY: skaffold
|
||||
skaffold: MODE ?= dev
|
||||
skaffold: skaffold/$(MODE)
|
||||
.SECONDEXPANSION:
|
||||
skaffold: skaffold/$$(MODE)
|
||||
|
||||
.PHONY: skaffold/%
|
||||
skaffold/%: PROFILE := local
|
||||
@@ -20,6 +21,8 @@ skaffold/%: skaffold.validate
|
||||
-f $(PWD)/hack/skaffold/virtual-kubelet/skaffold.yml \
|
||||
-p $(PROFILE)
|
||||
|
||||
skaffold/run skaffold/dev: bin/e2e/virtual-kubelet
|
||||
|
||||
bin/e2e:
|
||||
@mkdir -p bin/e2e
|
||||
|
||||
|
||||
Reference in New Issue
Block a user