d8dfun/virtual-kubelet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

skaffold target requires .SECONDEXPANSION (#696)

Browse Source 
Otherwise the variable is evaluated before it's even set (assuming it's
not set from the CLI).

skaffold also requires bin/e2e/virtual-kubelet to work on it's own.
This commit is contained in:
Brian Goff
2019-07-03 13:00:51 -07:00
committed by Pires
parent 1c4aa5d575
commit 327c6cf319
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Makefile.e2e
View File

@@ -11,7 +11,8 @@ skaffold.validate:
# MODE must be set to one of "dev" (default), "delete" or "run", and is used as the skaffold command to be run. # MODE must be set to one of "dev" (default), "delete" or "run", and is used as the skaffold command to be run.
.PHONY: skaffold .PHONY: skaffold
skaffold: MODE ?= dev skaffold: MODE ?= dev
skaffold: skaffold/$(MODE) .SECONDEXPANSION:
skaffold: skaffold/$$(MODE)
.PHONY: skaffold/% .PHONY: skaffold/%
skaffold/%: PROFILE := local skaffold/%: PROFILE := local
@@ -20,6 +21,8 @@ skaffold/%: skaffold.validate
-f $(PWD)/hack/skaffold/virtual-kubelet/skaffold.yml \ -f $(PWD)/hack/skaffold/virtual-kubelet/skaffold.yml \
-p $(PROFILE) -p $(PROFILE)
skaffold/run skaffold/dev: bin/e2e/virtual-kubelet
bin/e2e: bin/e2e:
@mkdir -p bin/e2e @mkdir -p bin/e2e