Merge pull request #77 from bnookala/node-exclusion-label-41

Node exclusion to labels, adding README section
This commit is contained in:
Ria Bhatia
2018-01-29 09:41:44 -08:00
committed by GitHub
2 changed files with 15 additions and 3 deletions

View File

@@ -20,6 +20,7 @@ The best description is "Kubernetes API on top, programmable back."
+ [Adding a New Provider via the Provider Interface](#adding-a-new-provider-via-the-provider-interface)
* [Testing](#testing)
+ [Testing the Azure Provider Client](#testing-the-azure-provider-client)
* [Known quirks and workarounds](#known-quirks-and-workaroundss)
* [Contributing](#contributing)
## How It Works
@@ -205,6 +206,19 @@ set to a credentials file.
You can generate this file by following the instructions listed in the
[README](providers/azure/client/README.md) for that package.
## Known quirks and workarounds
### Missing Load Balancer IP addresses for services
#### When Virtual Kubelet is installed on a cluster, I cannot create external-IPs for a Service
Kubernetes 1.9 introduces a new flag, `ServiceNodeExclusion`, for the control plane's Controller Manager. Enabling this flag in the Controller Manager's manifest allows Kubernetes to exclude Virtual Kubelet nodes from being added to Load Balancer pools, allowing you to create public facing services with external IPs without issue.
#### Workaround
Cluster requirements: Kubernetes 1.9 or above
Enable the ServiceNodeExclusion flag, by modifying the Controller Manager manifest and adding `--feature-gates=ServiceNodeExclusion=true` to the command line arguments.
## Contributing
@@ -218,4 +232,4 @@ provided by the bot. You will only need to do this once across all repos using o
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/).
For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or
contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.

View File

@@ -139,8 +139,6 @@ func (s *Server) registerNode() error {
"type": "virtual-kubelet",
"kubernetes.io/role": "agent",
"beta.kubernetes.io/os": strings.ToLower(s.provider.OperatingSystem()),
},
Annotations: map[string]string{
"alpha.service-controller.kubernetes.io/exclude-balancer": "true",
},
},