Fix error handling behaviour in nodeutil

Golang Lint v1.32.2 detects this case:
node/nodeutil/client.go:28:12: ineffectual assignment to `err` (ineffassign)
			config, err = rest.InClusterConfig()
			        ^
node/nodeutil/client.go:30:12: ineffectual assignment to `err` (ineffassign)
			config, err = clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
			        ^
This commit is contained in:
Sargun Dhillon
2020-11-06 17:05:30 -08:00
parent b4e62a645b
commit 544cca975f

View File

@@ -24,13 +24,16 @@ func ClientsetFromEnv(kubeConfigPath string) (*kubernetes.Clientset, error) {
)
if kubeConfigPath != "" {
if _, err := os.Stat(kubeConfigPath); err != nil {
config, err = rest.InClusterConfig()
} else {
_, err = os.Stat(kubeConfigPath)
if err == nil {
config, err = clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
&clientcmd.ClientConfigLoadingRules{ExplicitPath: kubeConfigPath},
&clientcmd.ConfigOverrides{},
).ClientConfig()
} else if os.IsNotExist(err) {
config, err = rest.InClusterConfig()
} else {
return nil, err
}
} else {
config, err = rest.InClusterConfig()