user %T instead of reflect.TypeOf

This commit is contained in:
robbiezhang
2018-10-18 20:06:03 +00:00
parent a6bab6e3bb
commit 966c76368f

View File

@@ -3,7 +3,6 @@ package vkubelet
import ( import (
"context" "context"
"fmt" "fmt"
"reflect"
"time" "time"
pkgerrors "github.com/pkg/errors" pkgerrors "github.com/pkg/errors"
@@ -33,8 +32,8 @@ func (s *Server) onAddPod(ctx context.Context, obj interface{}) {
pod, ok := obj.(*corev1.Pod) pod, ok := obj.(*corev1.Pod)
if !ok { if !ok {
span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)})
logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) logger.Errorf("obj is not of a valid type: %T", obj)
return return
} }
@@ -55,8 +54,8 @@ func (s *Server) onUpdatePod(ctx context.Context, obj interface{}) {
pod, ok := obj.(*corev1.Pod) pod, ok := obj.(*corev1.Pod)
if !ok { if !ok {
span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)})
logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) logger.Errorf("obj is not of a valid type: %T", obj)
return return
} }
@@ -79,14 +78,14 @@ func (s *Server) onDeletePod(ctx context.Context, obj interface{}) {
if !ok { if !ok {
delta, ok := obj.(cache.DeletedFinalStateUnknown) delta, ok := obj.(cache.DeletedFinalStateUnknown)
if !ok { if !ok {
span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)})
logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) logger.Errorf("obj is not of a valid type: %T", obj)
return return
} }
if pod, ok = delta.Obj.(*corev1.Pod); !ok { if pod, ok = delta.Obj.(*corev1.Pod); !ok {
span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %s", reflect.TypeOf(obj))}) span.SetStatus(trace.Status{Code: trace.StatusCodeInvalidArgument, Message: fmt.Sprintf("Unexpected object from event: %T", obj)})
logger.Errorf("obj is not of a valid type: %s", reflect.TypeOf(obj)) logger.Errorf("obj is not of a valid type: %T", obj)
return return
} }
} }